Refrain from sending hit report when user is in incognito mode

chrome/browser/safe_browsing/ui_manager.h

Index: chrome/browser/safe_browsing/ui_manager.h
diff --git a/chrome/browser/safe_browsing/ui_manager.h b/chrome/browser/safe_browsing/ui_manager.h
index 7ac91d41a3ccfc0140b901b76a627cfeaa0370eb..2c79777ea95ea13de099ae2b08af0bc6ef53d42f 100644
--- a/chrome/browser/safe_browsing/ui_manager.h
+++ b/chrome/browser/safe_browsing/ui_manager.h
@@ -71,8 +71,13 @@ class SafeBrowsingUIManager : public BaseUIManager {
   // to the server. Can only be called on UI thread.  If |post_data| is
   // non-empty, the request will be sent as a POST instead of a GET.
   // Will report only for UMA || is_extended_reporting.

[Jialiu Lin, 2017/05/18 22:32:12]

You can remove the last line of this comments, since it is already covered by
the comment above ShouldSendHitReport(..)

[mortonm, 2017/05/19 20:21:03]

Done.

-  void MaybeReportSafeBrowsingHit(
-      const safe_browsing::HitReport& hit_report) override;
+  void MaybeReportSafeBrowsingHit(const safe_browsing::HitReport& hit_report,
+                                  content::WebContents* web_contents) override;
+
+  // Helper method to ensure hit reports are only sent when the user has
+  // opted in to extended reporting and is not currently in incognito mode.
+  static bool ShouldSendHitReport(const HitReport& hit_report,

[Jialiu Lin, 2017/05/18 22:32:12]

How about moving this to protected session?

[mortonm, 2017/05/19 20:21:03]

Done.

+                                  content::WebContents* web_contents);
 
   // Report permission action to SafeBrowsing servers. Can only be called on UI
   // thread.