chrome/browser/safe_browsing/download_protection_service.cc - Issue 2886043002: Refrain from sending hit report when user is in incognito mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 2886043002: Refrain from sending hit report when user is in incognito mode (Closed)

Patch Set: ready for review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/download_protection_service.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc

index 7a886e32f03142460d6d9c8acba252feb55f01b7..c38104400db5d9515e965fd6d574f0a2e165ce7a 100644

--- a/chrome/browser/safe_browsing/download_protection_service.cc

+++ b/chrome/browser/safe_browsing/download_protection_service.cc

@@ -289,7 +289,8 @@ class DownloadUrlSBClient

hit_report.is_metrics_reporting_active =

ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled();

- ui_manager_->MaybeReportSafeBrowsingHit(hit_report);

+ ui_manager_->MaybeReportSafeBrowsingHit(hit_report,

+ item_->GetWebContents());

}

void IdentifyReferrerChain() {