Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 288603002: ozone: Add egltest platform (Closed)

Created:
6 years, 7 months ago by spang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

ozone: Add egltest platform This supports testing rendering using EGL. Creation of the EGLNativeWindowType is punted to a separate library, which has an interface defined in eglplatform_shim.h. TEST=content_shell --ozone-platform=egltest --ignore-gpu-blacklist BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270471

Patch Set 1 #

Patch Set 2 : deofficialize #

Total comments: 12

Patch Set 3 : nits #

Patch Set 4 : build fixup #

Patch Set 5 : drop EGL header dep from shim #

Unified diffs Side-by-side diffs Delta from patch set Stats (+557 lines, -7 lines) Patch
M build/all.gyp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M build/common.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/ozone.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
A ui/ozone/platform/egltest/eglplatform_shim.h View 1 2 3 4 1 chunk +58 lines, -0 lines 0 comments Download
A ui/ozone/platform/egltest/eglplatform_shim_xeleven.cc View 1 2 3 4 1 chunk +106 lines, -0 lines 0 comments Download
A ui/ozone/platform/egltest/egltest.gypi View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download
A + ui/ozone/platform/egltest/ozone_platform_egltest.h View 1 chunk +4 lines, -4 lines 0 comments Download
A ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 2 3 4 1 chunk +278 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
spang
6 years, 7 months ago (2014-05-13 20:50:45 UTC) #1
alexst (slow to review)
lgtm with nits. https://codereview.chromium.org/288603002/diff/20001/ui/ozone/platform/egltest/eglplatform_shim_xeleven.cc File ui/ozone/platform/egltest/eglplatform_shim_xeleven.cc (right): https://codereview.chromium.org/288603002/diff/20001/ui/ozone/platform/egltest/eglplatform_shim_xeleven.cc#newcode45 ui/ozone/platform/egltest/eglplatform_shim_xeleven.cc:45: ShimNativeWindowId ShimCreateWindow(const int* attrib_list) { I ...
6 years, 7 months ago (2014-05-13 22:11:14 UTC) #2
spang
https://codereview.chromium.org/288603002/diff/20001/ui/ozone/platform/egltest/eglplatform_shim_xeleven.cc File ui/ozone/platform/egltest/eglplatform_shim_xeleven.cc (right): https://codereview.chromium.org/288603002/diff/20001/ui/ozone/platform/egltest/eglplatform_shim_xeleven.cc#newcode45 ui/ozone/platform/egltest/eglplatform_shim_xeleven.cc:45: ShimNativeWindowId ShimCreateWindow(const int* attrib_list) { On 2014/05/13 22:11:14, alexst ...
6 years, 7 months ago (2014-05-13 22:28:07 UTC) #3
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-14 14:14:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/288603002/60001
6 years, 7 months ago (2014-05-14 14:15:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 15:58:27 UTC) #6
spang
The CQ bit was unchecked by spang@chromium.org
6 years, 7 months ago (2014-05-14 16:00:10 UTC) #7
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-14 16:10:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/288603002/80001
6 years, 7 months ago (2014-05-14 16:10:50 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 20:01:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 20:04:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/151918)
6 years, 7 months ago (2014-05-14 20:04:06 UTC) #12
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-14 20:16:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/288603002/80001
6 years, 7 months ago (2014-05-14 20:18:46 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 20:33:47 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 20:50:32 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/26798) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/31471)
6 years, 7 months ago (2014-05-14 20:50:32 UTC) #17
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-14 20:53:05 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/288603002/80001
6 years, 7 months ago (2014-05-14 20:55:25 UTC) #19
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 20:58:15 UTC) #20
Message was sent while issue was closed. 
Change committed as 270471

Powered by Google App Engine
This is Rietveld 408576698