Enable WebViewTest.NestedGuestContainerBounds for --site-per-process

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 468 matching lines @@
   RenderWidgetHostView* owner_rwhv = GetOwnerRenderWidgetHostView();
   if (!owner_rwhv)
     return relative_point;
 
   gfx::Point point(relative_point);
 
   // Add the offset form the embedder web contents view.
   point +=
       owner_rwhv->TransformPointToRootCoordSpace(guest_window_rect_.origin())
           .OffsetFromOrigin();
+  if (embedder_web_contents()->GetBrowserPluginGuest()) {
+    // |point| is currently with respect to the top-most view (outermost
+    // WebContents). We should subtract a displacement to find the point with
+    // resepct to embedder's WebContents.
+    point -= owner_rwhv->TransformPointToRootCoordSpace(gfx::Point())
+                 .OffsetFromOrigin();

[lfg, 2017/05/17 18:03:24]

Is this plus the transformation above the same as transforming the point to the
parent's coord space? There are functions to do that in
CrossProcessFrameConnector, but they aren't exposed in RenderWidgetHostView.

Is that something we should consider? It may not be worth it, since this is only
used for browser plugin.

WDYT?

[EhsanK, 2017/05/17 18:22:49]

Yes exactly.
Well we are inside content/ and they are exposed in RWHVBase so that should not
be a problem. The one I need is TransformPointToCoordSpaceForView.
The problem is the dependency on the implementation of
TransformPointToLocalCoordSpace or TransformPointToCoordSpaceForView for
RenderWidgetHostViewGuest. The RWHVG does not implement either so IMO it might
not be worth the effort (given that it is hopefully going away soon).

I could try implementing those if you think it is worth it.

+  }
+
   return point;
 }
 
 WebContentsImpl* BrowserPluginGuest::GetWebContents() const {
   return static_cast<WebContentsImpl*>(web_contents());
 }
 
 gfx::Point BrowserPluginGuest::GetScreenCoordinates(
     const gfx::Point& relative_position) const {
   if (!attached())
@@ skipping 562 matching lines @@
           range, character_bounds);
 }
 #endif
 
 void BrowserPluginGuest::SetContextMenuPosition(const gfx::Point& position) {
   if (delegate_)
     delegate_->SetContextMenuPosition(position);
 }
 
 }  // namespace content