Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2886013002: Enable WebViewTest.NestedGuestContainerBounds for --site-per-process (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <queue> 5 #include <queue>
6 #include <set> 6 #include <set>
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 3303 matching lines...) Expand 10 before | Expand all | Expand 10 after
3314 ASSERT_EQ(gvm->num_embedder_processes_destroyed(), 0); 3314 ASSERT_EQ(gvm->num_embedder_processes_destroyed(), 0);
3315 } 3315 }
3316 3316
3317 // Ensure that focusing a WebView while it is already focused does not blur the 3317 // Ensure that focusing a WebView while it is already focused does not blur the
3318 // guest content. 3318 // guest content.
3319 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestFocusWhileFocused) { 3319 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestFocusWhileFocused) {
3320 TestHelper("testFocusWhileFocused", "web_view/shim", NO_TEST_SERVER); 3320 TestHelper("testFocusWhileFocused", "web_view/shim", NO_TEST_SERVER);
3321 } 3321 }
3322 3322
3323 IN_PROC_BROWSER_TEST_P(WebViewTest, NestedGuestContainerBounds) { 3323 IN_PROC_BROWSER_TEST_P(WebViewTest, NestedGuestContainerBounds) {
3324 // TODO(lfg): https://crbug.com/581898
3325 if (base::FeatureList::IsEnabled(::features::kGuestViewCrossProcessFrames))
3326 return;
3327
3328 TestHelper("testPDFInWebview", "web_view/shim", NO_TEST_SERVER); 3324 TestHelper("testPDFInWebview", "web_view/shim", NO_TEST_SERVER);
3329 3325
3330 std::vector<content::WebContents*> guest_web_contents_list; 3326 std::vector<content::WebContents*> guest_web_contents_list;
3331 GetGuestViewManager()->WaitForNumGuestsCreated(2u); 3327 GetGuestViewManager()->WaitForNumGuestsCreated(2u);
3332 GetGuestViewManager()->GetGuestWebContentsList(&guest_web_contents_list); 3328 GetGuestViewManager()->GetGuestWebContentsList(&guest_web_contents_list);
3333 ASSERT_EQ(2u, guest_web_contents_list.size()); 3329 ASSERT_EQ(2u, guest_web_contents_list.size());
3334 3330
3335 content::WebContents* web_view_contents = guest_web_contents_list[0]; 3331 content::WebContents* web_view_contents = guest_web_contents_list[0];
3336 content::WebContents* mime_handler_view_contents = guest_web_contents_list[1]; 3332 content::WebContents* mime_handler_view_contents = guest_web_contents_list[1];
3337 3333
(...skipping 801 matching lines...) Expand 10 before | Expand all | Expand 10 after
4139 ClosingChromeSignInShouldNotCrash) { 4135 ClosingChromeSignInShouldNotCrash) {
4140 GURL signin_url{"chrome://chrome-signin"}; 4136 GURL signin_url{"chrome://chrome-signin"};
4141 4137
4142 AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED); 4138 AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED);
4143 AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED); 4139 AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED);
4144 WaitForWebViewInDom(); 4140 WaitForWebViewInDom();
4145 4141
4146 chrome::CloseTab(browser()); 4142 chrome::CloseTab(browser());
4147 } 4143 }
4148 #endif 4144 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698