Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2886003002: Suppressions for dart2js-drt roll 50. Issue 29632 (Closed)

Created:
3 years, 7 months ago by Alan Knight
Modified:
3 years, 7 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppressions for dart2js-drt roll 50. Issue 29632 BUG= Committed: https://github.com/dart-lang/sdk/commit/0ea9e4402d80a22de79fca24fd148c86fb4304b1

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -0 lines) Patch
M tests/co19/co19-dart2js.status View 1 1 chunk +141 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
Alan Knight
TBR
3 years, 7 months ago (2017-05-16 22:12:20 UTC) #2
Alan Knight
Committed patchset #2 (id:20001) manually as 0ea9e4402d80a22de79fca24fd148c86fb4304b1 (presubmit successful).
3 years, 7 months ago (2017-05-16 22:17:20 UTC) #4
Jacob
https://codereview.chromium.org/2886003002/diff/20001/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2886003002/diff/20001/tests/co19/co19-dart2js.status#newcode2555 tests/co19/co19-dart2js.status:2555: LayoutTests/fast/canvas/canvas-currentTransform_t01: Pass, RuntimeError # Issue 29634 Can we mark ...
3 years, 7 months ago (2017-05-17 00:02:51 UTC) #6
terry
3 years, 7 months ago (2017-05-17 13:18:47 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2886003002/diff/20001/tests/co19/co19-dart2js...
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/2886003002/diff/20001/tests/co19/co19-dart2js...
tests/co19/co19-dart2js.status:2555:
LayoutTests/fast/canvas/canvas-currentTransform_t01: Pass, RuntimeError # Issue
29634
On 2017/05/17 00:02:51, Jacob wrote:
> Can we mark the browsers the tests fail on rather than marking the tests
> as "pass, RuntimeError"?
> Test marked Pass, RuntimeError might as well be marked Skip.

They could start timing out (crash).  But in general I agree with you Jacob
having Pass/Timeout or Pass/RuntimeError is questionable.  Once we know what's
going on skip maybe the resolution.

Powered by Google App Engine
This is Rietveld 408576698