Issue 2885993005: Fix Stream.distinct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2885993005: Fix Stream.distinct. (Closed)

Created:
3 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
3 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix Stream.distinct. Due to incorrectly shared state, a broadcast distinct stream listened to more than once would give incorrect results. Also update docs. Fixes #29638, #29627. BUG= http://dartbug.com/29638, http://dartbug.com/29627 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/25a770fc974baca4d0637219fadff7f6078660f5

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -10 lines)			Patch
M	sdk/lib/async/stream.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sdk/lib/async/stream_pipe.dart	View	3 chunks	+24 lines, -10 lines	0 comments	Download
A	tests/lib/async/stream_distinct_test.dart	View	1 chunk	+126 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Lasse Reichstein Nielsen

3 years, 7 months ago (2017-05-18 14:54:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
25a770fc974baca4d0637219fadff7f6078660f5 (presubmit successful).