chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java - Issue 2885983002: Fixes intent chooser being shown incorrectly when going from HTTPS to HTTP for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

Issue 2885983002: Fixes intent chooser being shown incorrectly when going from HTTPS to HTTP for (Closed)

Patch Set: Minor cleanup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

index 9610a5e9793400a8b25155ec931f389b21b35cbe..f600142c646b5e3374310ece5b2e9771c7a91387 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

@@ -596,6 +596,11 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat

return false;

}

+ @Override

+ public String getPreviousUrl() {

+ return mTab.getWebContents().getLastCommittedUrl();

Maria 2017/05/17 00:29:18 You should do null checks on tab and web contents

troyhildebrandt 2017/05/17 20:19:10 Done.

+ }

/**

* Dispatches the intent through a proxy activity, so that startActivityForResult can be used

* and the intent recipient can verify the caller.