Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

Issue 2885963002: Implement type inference of static invocations. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
index de8c2a951847f0a69c493a39c3ce216046b25b49..38fda54600efd850d7abe06aa87e58bd29076acb 100644
--- a/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
@@ -547,8 +547,6 @@ abstract class TypeInferrerImpl extends TypeInferrer {
typeNeeded = listener.methodInvocationEnter(typeContext) || typeNeeded;
// First infer the receiver so we can look up the method that was invoked.
var receiverType = inferExpression(receiver, null, true);
- // TODO(paulberry): can we share some of the code below with
- // inferConstructorInvocation?
bool isOverloadedArithmeticOperator = false;
Member interfaceMember;
if (receiverType is InterfaceType) {
@@ -618,6 +616,44 @@ abstract class TypeInferrerImpl extends TypeInferrer {
return inferredType;
}
+ /// Performs the core type inference algorithm for method invocations.
+ ///
+ /// [typeContext], [typeNeeded], and the return value behave as described in
+ /// [inferExpression].
+ ///
+ /// [offset] is the location of the method invocation in the source file.
+ /// [receiver] is the object whose method is being invoked, and [methodName]
+ /// is the name of the method. [explicitTypeArguments] is the set of type
+ /// arguments explicitly provided, or `null` if no type arguments were
+ /// provided. [forEachArgument] is a callback which can be used to iterate
+ /// through all invocation arguments (both named and positional).
+ /// [setInferredTypeArguments] is a callback which can be used to record the
+ /// inferred type arguments. [setInterfaceTarget] is a callback which can be
+ /// used to record the method being invoked.
+ DartType inferStaticInvocation(
+ DartType typeContext,
+ bool typeNeeded,
+ int offset,
+ Procedure target,
+ Name methodName,
+ List<DartType> explicitTypeArguments,
+ void forEachArgument(void callback(String name, Expression expression)),
+ void setInferredTypeArguments(List<DartType> types)) {
+ typeNeeded = listener.staticInvocationEnter(typeContext) || typeNeeded;
+ var calleeType = target.function.functionType;
+ var inferredType = _inferInvocation(
+ typeContext,
+ typeNeeded,
+ offset,
+ calleeType,
+ calleeType.returnType,
+ explicitTypeArguments,
+ forEachArgument,
+ setInferredTypeArguments);
+ listener.staticInvocationExit(inferredType);
+ return inferredType;
+ }
+
/// Performs the core type inference algorithm for string concatenations.
///
/// [typeContext], [typeNeeded], and the return value behave as described in
@@ -789,6 +825,11 @@ abstract class TypeInferrerImpl extends TypeInferrer {
calleeTypeParameters.length == explicitTypeArguments.length) {
substitution =
Substitution.fromPairs(calleeTypeParameters, explicitTypeArguments);
+ } else if (calleeTypeParameters.length != 0) {
+ substitution = Substitution.fromPairs(
+ calleeTypeParameters,
+ new List<DartType>.filled(
+ calleeTypeParameters.length, const DynamicType()));
}
int i = 0;
forEachArgument((name, expression) {
« no previous file with comments | « pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart ('k') | pkg/front_end/test/fasta/strong.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698