Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2885963002: Implement type inference of static invocations. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -29 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +11 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 3 chunks +43 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 5 chunks +0 lines, -13 lines 0 comments Download
A pkg/front_end/testcases/inference/downwards_inference_on_function_arguments_infer_downwards.dart.strong.expect View 1 chunk +31 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_basic_downward_inference.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_dart_math_min_max.dart.strong.expect View 1 chunk +10 lines, -10 lines 0 comments Download
A pkg/front_end/testcases/inference/generic_methods_downwards_inference_affects_arguments.dart.strong.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/generic_methods_uses_greatest_lower_bound.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_variable_void.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_variable_void.dart.strong.expect View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_invoke_method.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_invoke_method.dart.strong.expect View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_invoke_method_via_interface.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_invoke_method_via_interface.dart.strong.expect View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_top_level_function.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/method_call_with_type_arguments_top_level_function.dart.strong.expect View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_implicit_type_param.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_no_type_param.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-16 21:29:13 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-16 23:46:03 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-17 01:33:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72d3fbc85fad2df5166d353bfca8d4d57ec438c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698