Implementing sign-in promo for "Other Devices" on the iPad

ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.h"
 
 #include "base/metrics/user_metrics.h"
 #include "base/metrics/user_metrics_action.h"
+#include "components/signin/core/browser/signin_metrics.h"
+#include "ios/chrome/browser/experimental_flags.h"
+#import "ios/chrome/browser/ui/authentication/signin_promo_view.h"
+#import "ios/chrome/browser/ui/authentication/signin_promo_view_configurator.h"
+#import "ios/chrome/browser/ui/authentication/signin_promo_view_consumer.h"
+#import "ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h"
 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
 #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 #import "ios/chrome/browser/ui/commands/show_signin_command.h"
 #import "ios/chrome/browser/ui/material_components/activity_indicator.h"
 #import "ios/chrome/browser/ui/sync/sync_util.h"
 #import "ios/chrome/browser/ui/tab_switcher/tab_switcher_model.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_chromium_strings.h"
 #include "ios/chrome/grit/ios_strings.h"
@@ skipping 26 matching lines @@
   }
 }
 
 namespace {
 const CGFloat kContainerOriginYOffset = -58.0;
 const CGFloat kContainerWidth = 400.0;
 const CGFloat kTitleMinimumLineHeight = 32.0;
 const CGFloat kSubtitleMinimunLineHeight = 24.0;
 }
 
-@interface TabSwitcherPanelOverlayView ()
+@interface TabSwitcherPanelOverlayView ()<SigninPromoViewConsumer>
 
 // Updates the texts of labels and button according to the current
 // |overlayType|.
 - (void)updateText;
 // Updates the button target and tag according to the current |overlayType|.
 - (void)updateButtonTarget;
 // Sends a SignIn chrome command.
 - (void)showSignIn;
 
 @end
 
 @implementation TabSwitcherPanelOverlayView {
   ios::ChromeBrowserState* _browserState;  // Weak.
   UIView* _container;
   UILabel* _titleLabel;
   UILabel* _subtitleLabel;
   MDCButton* _textButton;
   MDCButton* _floatingButton;
   MDCActivityIndicator* _activityIndicator;
   std::string _recordedMetricString;
+  SigninPromoViewMediator* _signinPromoViewMediator;
+  SigninPromoView* _signinPromoView;
 }
 
 @synthesize overlayType = _overlayType;
 
 - (instancetype)initWithFrame:(CGRect)frame
                  browserState:(ios::ChromeBrowserState*)browserState {
   self = [super initWithFrame:frame];
   if (self) {
     _browserState = browserState;
     // Create and add container. Will be vertically and horizontally centered.
@@ skipping 74 matching lines @@
       @"H:|-[subtitle]-|", @"H:[button(>=180)]", @"H:[floatingButton(==48)]"
     ];
     ApplyVisualConstraints(constraints, viewsDictionary, _container);
 
     // Sets the container's width relative to the parent.
     ApplyVisualConstraintsWithMetrics(
         @[
           @"H:|-(>=0)-[container(==containerWidth@999)]-(>=0)-|",
         ],
         @{ @"container" : _container },
-        @{ @"containerWidth" : @(kContainerWidth) }, self);
+        @{ @"containerWidth" : @(kContainerWidth) });
+
+    // Adding sign-in promo view.

[msarda, 2017/05/23 12:55:54]

It looks like the sign-in promo view is created even when the user is signed in.
I think that we should avoid creating the sign-in promo view when the overlay
type is different than OVERLAY_PANEL_USER_SIGNED_OUT

[jlebel, 2017/05/23 14:34:15]

Done.

+    _signinPromoView = [[SigninPromoView alloc] initWithFrame:CGRectZero];
+    _signinPromoView.translatesAutoresizingMaskIntoConstraints = NO;
+    _signinPromoView.textLabel.text =
+        l10n_util::GetNSString(IDS_IOS_SIGNIN_PROMO_SETTINGS);

[msarda, 2017/05/23 12:55:55]

Why are we using the settings promo string in the recent tabs?

[jlebel, 2017/05/23 14:34:15]

Done.

+    _signinPromoView.textLabel.textColor = [UIColor whiteColor];
+    _signinPromoView.textLabel.font = [MDCTypography headlineFont];
+    _signinPromoView.textLabel.preferredMaxLayoutWidth =
+        kContainerWidth - (2 * _signinPromoView.horizontalPadding);
+    [self addSubview:_signinPromoView];
+    ApplyVisualConstraintsWithMetrics(
+        @[ @"H:[signinPromoView(containerWidth)]" ],
+        @{ @"signinPromoView" : _signinPromoView },
+        @{ @"containerWidth" : @(kContainerWidth) });
+    AddSameCenterXConstraint(_signinPromoView, self);
+    [_signinPromoView.centerYAnchor
+        constraintEqualToAnchor:self.centerYAnchor
+                       constant:kContainerOriginYOffset]
+        .active = YES;
+    _signinPromoView.hidden = YES;
+    _signinPromoViewMediator = [[SigninPromoViewMediator alloc] init];
+    _signinPromoViewMediator.accessPoint =
+        signin_metrics::AccessPoint::ACCESS_POINT_RECENT_TABS;
+    _signinPromoView.delegate = _signinPromoViewMediator;
+    _signinPromoViewMediator.consumer = self;
+    [[_signinPromoViewMediator createConfigurator]
+        configureSigninPromoView:_signinPromoView];
+    [_signinPromoView setNeedsLayout];

[msarda, 2017/05/23 12:55:55]

Why should the sign-in promo view be layed out if it is hidden?

[jlebel, 2017/05/23 14:34:15]

I've done it just to make sure the layout is correct when it will shown. But
there is no reason anyway for this line since we just created the view, and the
layout has to be made anyway. 

   }
   return self;
 }
 
 - (void)layoutSubviews {
   [super layoutSubviews];
   CGRect containerFrame = [_container frame];
   containerFrame.origin.x =
       (self.frame.size.width - containerFrame.size.width) / 2;
   containerFrame.origin.y =
       (self.frame.size.height - containerFrame.size.height) / 2 +
       kContainerOriginYOffset;
   [_container setFrame:containerFrame];
 }
 
 - (void)setOverlayType:(TabSwitcherPanelOverlayType)overlayType {
   _overlayType = overlayType;
-  [self updateText];
-  [self updateButtonTarget];
+  if (experimental_flags::IsSigninPromoEnabled() &&
+      _overlayType ==
+          TabSwitcherPanelOverlayType::OVERLAY_PANEL_USER_SIGNED_OUT) {
+    _container.hidden = YES;
+    _signinPromoView.hidden = NO;
+  } else {
+    _container.hidden = NO;
+    _signinPromoView.hidden = YES;
+    [self updateText];

[msarda, 2017/05/23 12:55:55]

When the promo is enabled, it looks like we do not call updateText or
updateButtonTarget when the overlay type is SIGNED_OUT. However we still call it
for the other cases. Is that expected?

[jlebel, 2017/05/23 14:34:15]

In this overlay view, I can't use the current UI element. I choose to add the
SigninPromoView on top and hide one or the other. So if the sign-in promo view
is shown there is no reason to update the hidden elements.

+    [self updateButtonTarget];
+  }
 }
 
 #pragma mark - Private
 
 - (void)updateText {
   NSMutableAttributedString* titleString = nil;
   NSMutableAttributedString* subtitleString = nil;
 
   NSString* buttonTitle = nil;
   UIImage* buttonImage = nil;
   NSString* buttonAccessibilityLabel = nil;
   UIColor* floatingButtonNormalBackgroundColor = nil;
   UIColor* floatingButtonDisabledBackgroundColor = nil;
   UIColor* floatingButtonInkColor = nil;
   BOOL spinnerIsHidden = YES;
   switch (self.overlayType) {
     case TabSwitcherPanelOverlayType::OVERLAY_PANEL_EMPTY:
       break;
     case TabSwitcherPanelOverlayType::OVERLAY_PANEL_USER_SIGNED_OUT:

[msarda, 2017/05/23 12:55:55]

Maybe: DCHECK(!experimental_flags::IsSigninPromoEnabled());

[jlebel, 2017/05/23 14:34:15]

Done.

       titleString = [[NSMutableAttributedString alloc]
           initWithString:l10n_util::GetNSString(
                              IDS_IOS_TAB_SWITCHER_SIGN_IN_ACCOUNT_TITLE)];
       subtitleString = [[NSMutableAttributedString alloc]
           initWithString:l10n_util::GetNSString(
                              IDS_IOS_TAB_SWITCHER_SIGN_IN_ACCOUNT_PROMO)];
       buttonTitle =
           l10n_util::GetNSString(IDS_IOS_TAB_SWITCHER_SIGN_IN_ACCOUNT_BUTTON);
       break;
     case TabSwitcherPanelOverlayType::OVERLAY_PANEL_USER_SIGNED_IN_SYNC_OFF:
@@ skipping 184 matching lines @@
 - (void)rootViewControllerChromeCommand:(id)command {
   [self chromeExecuteCommand:command];
 }
 
 - (void)recordMetrics {
   if (!_recordedMetricString.length())
     return;
   base::RecordAction(base::UserMetricsAction(_recordedMetricString.c_str()));
 }
 
+#pragma mark - SigninPromoViewConsumer
+
+- (void)configureSigninPromoViewWithNewIdentity:(BOOL)newIdentity
+                                   configurator:(SigninPromoViewConfigurator*)
+                                                    configurator {
+  [configurator configureSigninPromoView:_signinPromoView];
+}
+
 @end