arc: Consolidate IsArcAllowedForUser logic

components/arc/arc_util_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/arc_util.h"
 
 #include <memory>
 #include <string>
 
 #include "ash/shared/app_types.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/test/scoped_feature_list.h"
+#include "components/signin/core/account_id/account_id.h"
+#include "components/user_manager/fake_user_manager.h"
+#include "components/user_manager/user.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/test/test_windows.h"
 #include "ui/aura/window.h"
 
 namespace arc {
 namespace {
 
 // If an instance is created, based on the value passed to the consturctor,
 // EnableARC feature is enabled/disabled in the scope.
 class ScopedArcFeature {
  public:
   explicit ScopedArcFeature(bool enabled) {
     constexpr char kArcFeatureName[] = "EnableARC";
     if (enabled) {
       feature_list.InitFromCommandLine(kArcFeatureName, std::string());
     } else {
       feature_list.InitFromCommandLine(std::string(), kArcFeatureName);
     }
   }
   ~ScopedArcFeature() = default;
 
  private:
   base::test::ScopedFeatureList feature_list;
   DISALLOW_COPY_AND_ASSIGN(ScopedArcFeature);
 };
 
+// Helper to enable user_manager::FakeUserManager while it is in scope.
+// TODO(xiyuan): Remove after ScopedUserManagerEnabler is moved to user_manager.
+class ScopedUserManager {
+ public:
+  explicit ScopedUserManager(user_manager::UserManager* user_manager)
+      : user_manager_(user_manager) {
+    DCHECK(!user_manager::UserManager::IsInitialized());
+    user_manager->Initialize();
+  }
+  ~ScopedUserManager() {
+    DCHECK_EQ(user_manager::UserManager::Get(), user_manager_);
+    user_manager_->Shutdown();
+    user_manager_->Destroy();
+  }
+
+ private:
+  user_manager::UserManager* const user_manager_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScopedUserManager);
+};
+
+// Fake user that can be created with a specified type.
+class FakeUser : public user_manager::User {
+ public:
+  explicit FakeUser(user_manager::UserType user_type)
+      : User(AccountId::FromUserEmail("user@test.com")),
+        user_type_(user_type) {}
+  ~FakeUser() override = default;
+
+  // user_manager::User:
+  user_manager::UserType GetType() const override { return user_type_; }
+
+ private:
+  const user_manager::UserType user_type_;
+
+  DISALLOW_COPY_AND_ASSIGN(FakeUser);
+};
+
 using ArcUtilTest = testing::Test;
 
 TEST_F(ArcUtilTest, IsArcAvailable_None) {
   auto* command_line = base::CommandLine::ForCurrentProcess();
 
   command_line->InitFromArgv({"", "--arc-availability=none"});
   EXPECT_FALSE(IsArcAvailable());
 
   // If --arc-availability flag is set to "none", even if Finch experiment is
   // turned on, ARC cannot be used.
@@ skipping 123 matching lines @@
   window->SetProperty(aura::client::kAppType,
                       static_cast<int>(ash::AppType::CHROME_APP));
   EXPECT_FALSE(IsArcAppWindow(window.get()));
   window->SetProperty(aura::client::kAppType,
                       static_cast<int>(ash::AppType::ARC_APP));
   EXPECT_TRUE(IsArcAppWindow(window.get()));
 
   EXPECT_FALSE(IsArcAppWindow(nullptr));
 }
 
+TEST_F(ArcUtilTest, IsArcAllowedForUser) {
+  user_manager::FakeUserManager fake_user_manager;
+  ScopedUserManager scoped_user_manager(&fake_user_manager);
+
+  struct {
+    user_manager::UserType user_type;
+    bool expected_allowed;
+  } const kTestCases[] = {
+      {user_manager::USER_TYPE_REGULAR, true},
+      {user_manager::USER_TYPE_GUEST, false},
+      {user_manager::USER_TYPE_PUBLIC_ACCOUNT, false},
+      {user_manager::USER_TYPE_SUPERVISED, false},
+      {user_manager::USER_TYPE_KIOSK_APP, false},
+      {user_manager::USER_TYPE_CHILD, true},
+      {user_manager::USER_TYPE_ARC_KIOSK_APP, false},
+      {user_manager::USER_TYPE_ACTIVE_DIRECTORY, false},
+  };
+  for (const auto& test_case : kTestCases) {
+    const FakeUser user(test_case.user_type);
+    EXPECT_EQ(test_case.expected_allowed, IsArcAllowedForUser(&user))
+        << "User type=" << test_case.user_type;
+  }
+
+  // Active directory users are allowed when ARC is supported for active
+  // directory managed devices.
+  auto* command_line = base::CommandLine::ForCurrentProcess();
+  command_line->InitFromArgv(
+      {"", "--arc-availability=officially-supported-with-active-directory"});

[hidehiko, 2017/05/18 18:52:50]

This is flag is being deprecated (as you looks rebasing on top of the removing
CL?)

[xiyuan, 2017/05/22 20:58:18]

Removed after rebase.

+  const FakeUser active_directory_user(
+      user_manager::USER_TYPE_ACTIVE_DIRECTORY);
+  EXPECT_TRUE(IsArcAllowedForUser(&active_directory_user));
+
+  // An ephemeral user is a logged in user but unknown to UserManager when
+  // ephemeral policy is set.
+  fake_user_manager.SetEphemeralUsersEnabled(true);
+  fake_user_manager.UserLoggedIn(AccountId::FromUserEmail("test@test.com"),
+                                 "test@test.com-hash", false);
+  const user_manager::User* ephemeral_user = fake_user_manager.GetActiveUser();
+  ASSERT_TRUE(ephemeral_user && fake_user_manager.IsUserCryptohomeDataEphemeral(

[hidehiko, 2017/05/18 18:52:50]

nit/style: How about splitting two ASSERT_TRUEs?
So that what happens can be easily detected.

[xiyuan, 2017/05/22 20:58:18]

Done.

+                                    ephemeral_user->GetAccountId()));
+
+  // Ephemeral user is not allowed for ARC.
+  EXPECT_FALSE(IsArcAllowedForUser(ephemeral_user));
+}
+
 }  // namespace
 }  // namespace arc