arc: Consolidate IsArcAllowedForUser logic

components/user_manager/fake_user_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_USER_MANAGER_FAKE_USER_MANAGER_H_
 #define COMPONENTS_USER_MANAGER_FAKE_USER_MANAGER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 14 matching lines @@
   // Create and add a new user. Created user is not affiliated with the domain,
   // that owns the device.
   virtual const user_manager::User* AddUser(const AccountId& account_id);
 
   // The same as AddUser() but allows to specify user affiliation with the
   // domain, that owns the device.
   virtual const user_manager::User* AddUserWithAffiliation(
       const AccountId& account_id,
       bool is_affiliated);
 
-  // Calculates the user name hash and calls UserLoggedIn to login a user.
-  void LoginUser(const AccountId& account_id);

[xiyuan, 2017/05/17 21:36:14]

Stale code with no impl.

-
   // UserManager overrides.
   const user_manager::UserList& GetUsers() const override;
   user_manager::UserList GetUsersAllowedForMultiProfile() const override;
-  const user_manager::UserList& GetLoggedInUsers() const override;

[xiyuan, 2017/05/17 21:36:14]

Removed because it is the same as base class impl.

 
   // Set the user as logged in.
   void UserLoggedIn(const AccountId& account_id,
                     const std::string& username_hash,
                     bool browser_restart) override;
 
   const user_manager::User* GetActiveUser() const override;
   user_manager::User* GetActiveUser() override;
   void SwitchActiveUser(const AccountId& account_id) override;
   void SaveUserDisplayName(const AccountId& account_id,
@@ skipping 60 matching lines @@
   bool IsSupervisedAccountId(const AccountId& account_id) const override;
   const gfx::ImageSkia& GetResourceImagekiaNamed(int id) const override;
   base::string16 GetResourceStringUTF16(int string_id) const override;
   void ScheduleResolveLocale(const std::string& locale,
                              const base::Closure& on_resolved_callback,
                              std::string* out_resolved_locale) const override;
   bool IsValidDefaultUserImageId(int image_index) const override;
 
   // UserManagerBase overrides:
   bool AreEphemeralUsersEnabled() const override;
+  void SetEphemeralUsersEnabled(bool enabled) override;
   const std::string& GetApplicationLocale() const override;
   PrefService* GetLocalState() const override;
   void HandleUserOAuthTokenStatusChange(
       const AccountId& account_id,
       user_manager::User::OAuthTokenStatus status) const override {}
   bool IsEnterpriseManaged() const override;
   void LoadDeviceLocalAccounts(
       std::set<AccountId>* device_local_accounts_set) override {}
   void PerformPreUserListLoadingActions() override {}
   void PerformPostUserListLoadingActions() override {}
@@ skipping 24 matching lines @@
 
   // stub. Always empty.
   gfx::ImageSkia empty_image_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeUserManager);
 };
 
 }  // namespace user_manager
 
 #endif  // COMPONENTS_USER_MANAGER_FAKE_USER_MANAGER_H_