arc: Consolidate IsArcAllowedForUser logic

components/arc/arc_util.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/arc_util.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
@@ skipping 76 matching lines @@
 void SetArcAvailableCommandLineForTesting(base::CommandLine* command_line) {
   command_line->AppendSwitchASCII(chromeos::switches::kArcAvailability,
                                   kAvailabilityOfficiallySupported);
 }
 
 bool IsArcKioskMode() {
   return user_manager::UserManager::IsInitialized() &&
          user_manager::UserManager::Get()->IsLoggedInAsArcKioskApp();
 }
 
+bool IsArcAllowedForUser(const user_manager::User* user) {
+  return user &&

[hidehiko, 2017/05/17 02:09:45]

Instead of oneline, could you use if-stmt, and vlog for each not-allowed case?

E.g.;

if (!user->HasGaiaAccount()) {
  VLOG(1) << "User does not have gaia account.";
  return false;
}
  :

etc.?

[xiyuan, 2017/05/17 21:36:14]

Done.

+         (user->HasGaiaAccount() || (user->IsActiveDirectoryUser() &&
+                                     IsArcAllowedForActiveDirectoryUsers()));
+}
+
 bool IsArcAllowedForActiveDirectoryUsers() {
   const auto* command_line = base::CommandLine::ForCurrentProcess();
 
   if (!command_line->HasSwitch(chromeos::switches::kArcAvailability))
     return false;
 
   return command_line->GetSwitchValueASCII(
              chromeos::switches::kArcAvailability) ==
          kAvailabilityOfficiallySupportedWithActiveDirectory;
 }
 
 bool IsArcOptInVerificationDisabled() {
   const auto* command_line = base::CommandLine::ForCurrentProcess();
   return command_line->HasSwitch(
       chromeos::switches::kDisableArcOptInVerification);
 }
 
 }  // namespace arc