arc: Consolidate IsArcAllowedForUser logic

chrome/browser/chromeos/login/screens/user_selection_screen.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/screens/user_selection_screen.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 133 matching lines @@
 
 // Returns true if dircrypto migration check should be performed.
 bool ShouldCheckNeedDircryptoMigration() {
   return !base::CommandLine::ForCurrentProcess()->HasSwitch(
              switches::kDisableEncryptionMigration) &&
          arc::IsArcAvailable();
 }
 
 // Returns true if the user can run ARC based on the user type.
 bool IsUserAllowedForARC(const AccountId& account_id) {
-  if (!user_manager::UserManager::IsInitialized())
-    return false;
-
-  const user_manager::User* user =
-      user_manager::UserManager::Get()->FindUser(account_id);
-  if (!user)
-    return false;
-
-  return user->HasGaiaAccount() || user->IsActiveDirectoryUser();
+  return user_manager::UserManager::IsInitialized() &&
+         arc::IsArcAllowedForUser(
+             user_manager::UserManager::Get()->FindUser(account_id));

[hidehiko, 2017/05/23 07:23:26]

Clarification: Just in case, this change make behavior difference in case of
Kiosk, IIUC. Is it intentional?

[xiyuan, 2017/05/24 19:22:56]

It is okay because the function is called for user pods banners. Kiosk users do
not have pods on the login screen. So the behvaior change should be no impact on
kiosk users.

 }
 
 }  // namespace
 
 // Helper class to call cryptohome to check whether a user needs dircrypto
 // migration. The check results are cached to limit calls to cryptohome.
 class UserSelectionScreen::DircryptoMigrationChecker {
  public:
   explicit DircryptoMigrationChecker(UserSelectionScreen* owner)
       : owner_(owner), weak_ptr_factory_(this) {}
@@ skipping 539 matching lines @@
   // The user profile should exist if and only if this is the lock screen.
   DCHECK_EQ(!!profile, GetScreenType() == LOCK_SCREEN);
 
   if (!profile)
     profile = profile_helper->GetSigninProfile();
 
   return EasyUnlockService::Get(profile);
 }
 
 }  // namespace chromeos