Fix computing export scopes for library cycles and after loading.

pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:front_end/file_system.dart';
 import 'package:front_end/incremental_kernel_generator.dart';
 import 'package:front_end/incremental_resolved_ast_generator.dart';
@@ skipping 141 matching lines @@
           signatureBuilder.addString(file.uri.toString());
           // TODO(scheglov) use API signature
           signatureBuilder.addBytes(file.contentHash);
         }
         signature = signatureBuilder.toHex();
       }
 
       _logger.writeln('Signature: $signature.');
       String kernelKey = '$signature.kernel';
 
-      /// We need kernel libraries for these URIs.
+      // We need kernel libraries for these URIs.
       Set<Uri> libraryUris = new Set<Uri>();
       Map<Uri, FileState> libraryUriToFile = {};
       for (FileState library in cycle.libraries) {
         Uri uri = library.uri;
         libraryUris.add(uri);
         libraryUriToFile[uri] = library;
       }
 
-      /// Check if there is already a bundle with these libraries.
+      Future<Null> appendNewDillLibraries(Program program) async {
+        List<DillLibraryBuilder> libraryBuilders = dillTarget.loader
+            .appendLibraries(program, (uri) => libraryUris.contains(uri));
+
+        // Compute local scopes.
+        await dillTarget.writeOutline(null);
+
+        // Compute export scopes.
+        _computeExportScopes(dillTarget, libraryUriToFile, libraryBuilders);
+      }
+
+      // Check if there is already a bundle with these libraries.
       List<int> bytes = _byteStore.get(kernelKey);
       if (bytes != null) {
-        return _logger.run('Read serialized libraries', () {
+        return _logger.runAsync('Read serialized libraries', () async {
           var program = new Program(nameRoot: nameRoot);
           var reader = new BinaryBuilder(bytes);
           reader.readProgram(program);
 
-          List<DillLibraryBuilder> libraryBuilders = dillTarget.loader
-              .appendLibraries(program, (uri) => libraryUris.contains(uri));
-          _computeExportScopes(dillTarget, libraryUriToFile, libraryBuilders);
+          await appendNewDillLibraries(program);
 
           return new _LibraryCycleResult(cycle, signature, program.libraries);
         });
       }
 
-      // Ask DILL to fill outlines using loaded libraries.
-      await dillTarget.writeOutline(null);
-
       // Create KernelTarget and configure it for compiling the cycle URIs.
       KernelTarget kernelTarget = new KernelTarget(_fsState.fileSystemView,
           dillTarget, _uriTranslator, _options.strongMode);
       for (FileState library in cycle.libraries) {
         kernelTarget.read(library.uri);
       }
 
       // Compile the cycle libraries into a new full program.
-      Program program = await _logger.runAsync(
-          'Compile ${cycle.libraries.length} cycle libraries', () async {
+      Program program = await _logger
+          .runAsync('Compile ${cycle.libraries.length} libraries', () async {
         await kernelTarget.writeOutline(null, nameRoot: nameRoot);
         return await kernelTarget.writeProgram(null);
       });
 
       // Add newly compiled libraries into DILL.
+      await appendNewDillLibraries(program);
+
       List<Library> kernelLibraries = program.libraries
           .where((library) => libraryUris.contains(library.importUri))
           .toList();
-      List<DillLibraryBuilder> libraryBuilders = dillTarget.loader
-          .appendLibraries(program, (uri) => libraryUris.contains(uri));
-      _computeExportScopes(dillTarget, libraryUriToFile, libraryBuilders);
 
       _logger.run('Serialize ${kernelLibraries.length} libraries', () {
         program.unbindCanonicalNames();
         List<int> bytes = _writeProgramBytes(program, kernelLibraries.contains);
         _byteStore.put(kernelKey, bytes);
         _logger.writeln('Stored ${bytes.length} bytes.');
       });
 
       return new _LibraryCycleResult(cycle, signature, kernelLibraries);
     });
@@ skipping 58 matching lines @@
   /// TODO(scheglov) Use API signatures.
   /// TODO(scheglov) Or use tree shaking and compute signatures of outlines.
   final String signature;
 
   /// Kernel libraries for libraries in the [cycle].  Dependencies are not
   /// included, they were returned as results for preceding cycles.
   final List<Library> kernelLibraries;
 
   _LibraryCycleResult(this.cycle, this.signature, this.kernelLibraries);
 }