ios/chrome/browser/tabs/tab.mm - Issue 2885803002: [ios] Remove TabModel cleanup from -dealloc to -browserStateDestroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2885803002: [ios] Remove TabModel cleanup from -dealloc to -browserStateDestroyed. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab.mm

diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm

index ead02b4ef5f3c2ce1dd0fe1dd391c8502a017028..718c7d8685b9dd16717a07223f988387622d8206 100644

--- a/ios/chrome/browser/tabs/tab.mm

+++ b/ios/chrome/browser/tabs/tab.mm

@@ -1012,7 +1012,9 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,

[_openInController detachFromWebController];

_openInController = nil;

[_autofillController detachFromWebState];

+ _autofillController = nil;

[_suggestionController detachFromWebState];

+ _suggestionController = nil;

if (_fullScreenController)

[self.webController removeObserver:_fullScreenController];

[_fullScreenController invalidate];

« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab_model.mm » ('j') | ios/chrome/browser/tabs/tab_model.mm » ('J')