Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: ios/chrome/browser/tabs/tab.mm

Issue 2885803002: [ios] Remove TabModel cleanup from -dealloc to -browserStateDestroyed. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/tabs/tab.h" 5 #import "ios/chrome/browser/tabs/tab.h"
6 6
7 #import <CoreLocation/CoreLocation.h> 7 #import <CoreLocation/CoreLocation.h>
8 #import <UIKit/UIKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 #include <utility> 10 #include <utility>
(...skipping 994 matching lines...) Expand 10 before | Expand all | Expand 10 after
1005 [[NSNotificationCenter defaultCenter] removeObserver:self]; 1005 [[NSNotificationCenter defaultCenter] removeObserver:self];
1006 1006
1007 [passwordController_ detach]; 1007 [passwordController_ detach];
1008 passwordController_ = nil; 1008 passwordController_ = nil;
1009 _tabInfoBarObserver.reset(); 1009 _tabInfoBarObserver.reset();
1010 1010
1011 _faviconDriverObserverBridge.reset(); 1011 _faviconDriverObserverBridge.reset();
1012 [_openInController detachFromWebController]; 1012 [_openInController detachFromWebController];
1013 _openInController = nil; 1013 _openInController = nil;
1014 [_autofillController detachFromWebState]; 1014 [_autofillController detachFromWebState];
1015 _autofillController = nil;
1015 [_suggestionController detachFromWebState]; 1016 [_suggestionController detachFromWebState];
1017 _suggestionController = nil;
1016 if (_fullScreenController) 1018 if (_fullScreenController)
1017 [self.webController removeObserver:_fullScreenController]; 1019 [self.webController removeObserver:_fullScreenController];
1018 [_fullScreenController invalidate]; 1020 [_fullScreenController invalidate];
1019 _fullScreenController = nil; 1021 _fullScreenController = nil;
1020 if (_overscrollActionsController) 1022 if (_overscrollActionsController)
1021 [self.webController removeObserver:_overscrollActionsController]; 1023 [self.webController removeObserver:_overscrollActionsController];
1022 [_overscrollActionsController invalidate]; 1024 [_overscrollActionsController invalidate];
1023 _overscrollActionsController = nil; 1025 _overscrollActionsController = nil;
1024 [readerModeController_ detachFromWebState]; 1026 [readerModeController_ detachFromWebState];
1025 readerModeController_ = nil; 1027 readerModeController_ = nil;
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
1899 1901
1900 - (TabModel*)parentTabModel { 1902 - (TabModel*)parentTabModel {
1901 return _parentTabModel; 1903 return _parentTabModel;
1902 } 1904 }
1903 1905
1904 - (FormInputAccessoryViewController*)inputAccessoryViewController { 1906 - (FormInputAccessoryViewController*)inputAccessoryViewController {
1905 return _inputAccessoryViewController; 1907 return _inputAccessoryViewController;
1906 } 1908 }
1907 1909
1908 @end 1910 @end
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab_model.mm » ('j') | ios/chrome/browser/tabs/tab_model.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698