Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2885793003: ** DO NOT COMMIT** Only for test

Created:
3 years, 7 months ago by zino
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, tzik, yzshen+watch_chromium.org, agrieve+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, dglazkov+blink, darin-cc_chromium.org, blink-reviews, gogerald+paymentswatch_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, rouslan+payments_chromium.org, haraken, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-api_chromium.org, Aaron Boodman, kinuko+serviceworker, mahmadi+paymentswatch_chromium.org, horo+watch_chromium.org, darin (slow to review), sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only for test BUG=

Patch Set 1 #

Patch Set 2 : Replace yaho #

Patch Set 3 : Replace yaho #

Patch Set 4 : Replace yaho #

Patch Set 5 : Replace yaho #

Patch Set 6 : Replace yaho #

Patch Set 7 : Replace yaho #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -59 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java View 1 2 chunks +20 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentInstrument.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/android/payments/service_worker_payment_app_bridge.cc View 2 chunks +21 lines, -12 lines 0 comments Download
M components/payments/mojom/payment_app.mojom View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/payments/payment_app_browsertest.cc View 1 2 3 4 5 2 chunks +15 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_type_converters.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/payments/resources/payment-request-event.js View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppRequest.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp View 1 2 3 4 5 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppRequestConversionTest.cpp View 3 chunks +15 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h View 2 chunks +17 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp View 3 chunks +36 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl View 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/payments/WebPaymentAppRequest.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (27 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885793003/100001
3 years, 7 months ago (2017-05-19 05:09:51 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 05:09:53 UTC) #24
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698