Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 288573003: Change ImageStore to use SequenceChecker instead of ThreadChecker. (Closed)

Created:
6 years, 7 months ago by Kibeom Kim (inactive)
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Change ImageStore to use SequenceChecker instead of ThreadChecker. We will be using ImageStore with BrowserThread::PostBlockingPoolSequencedTask which doesn't always guarantee same thread execution. BUG=368034 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270801

Patch Set 1 #

Patch Set 2 : moved thread checking to persistent_image_store.cc for consistency #

Patch Set 3 : git log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M components/enhanced_bookmarks/image_store.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/image_store.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/enhanced_bookmarks/persistent_image_store.cc View 1 2 8 chunks +9 lines, -9 lines 0 comments Download
M components/enhanced_bookmarks/test_image_store.cc View 1 2 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Kibeom Kim (inactive)
6 years, 7 months ago (2014-05-13 21:54:23 UTC) #1
Kibeom Kim (inactive)
6 years, 7 months ago (2014-05-13 21:54:26 UTC) #2
sky
I think ImageStore should only be created and used on a single thread. That way ...
6 years, 7 months ago (2014-05-13 22:15:03 UTC) #3
Kibeom Kim (inactive)
changed to use SequenceChecker, ptal.
6 years, 7 months ago (2014-05-15 12:52:10 UTC) #4
sky
LGTM
6 years, 7 months ago (2014-05-15 16:44:53 UTC) #5
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 7 months ago (2014-05-15 16:47:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/288573003/40001
6 years, 7 months ago (2014-05-15 16:50:09 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 18:34:42 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 20:35:50 UTC) #9
Message was sent while issue was closed.
Change committed as 270801

Powered by Google App Engine
This is Rietveld 408576698