Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 288573002: Updating DevTools links - top nav (Closed)

Created:
6 years, 7 months ago by pearlchen
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, mkearney, paulirish
Visibility:
Public.

Description

Change log 1) No change to "Additional Resources" or "Inspecting & Tweaking" labels in fatnav 2) Renamed some of the favnav labels during the meeting 3) /devtools/docs/elements completely removed from chrome_sidenav.json so we shouldn't be able to get to it unless you go to the direct url 4) /devtools/docs/dom-and-styles added properly to chrome_sidenav.json BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271210

Patch Set 1 #

Patch Set 2 : Revised tweaks to the fatnav #

Patch Set 3 : Removed dupe resource-panel reference from chrome_sidebar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 2 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pearlchen
Minor updates to top navigation dropdown. paulirish was there when I made the changes so ...
6 years, 7 months ago (2014-05-16 18:17:41 UTC) #1
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-16 18:19:17 UTC) #2
pearlchen
The CQ bit was checked by pearlchen@chromium.org
6 years, 7 months ago (2014-05-16 18:21:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pearlchen@chromium.org/288573002/30001
6 years, 7 months ago (2014-05-16 18:21:51 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 15:43:51 UTC) #5
Message was sent while issue was closed.
Change committed as 271210

Powered by Google App Engine
This is Rietveld 408576698