Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 2885633002: Style tag in an XHR's responseXML shouldn't make the responseXML be null. (Closed)
Patch Set: Move setting Document::well_formed_ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org> 3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org>
4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org> 4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org>
5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved. 5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved.
6 * Copyright (C) 2012 Intel Corporation 6 * Copyright (C) 2012 Intel Corporation
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public 9 * modify it under the terms of the GNU Lesser General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1620 matching lines...) Expand 10 before | Expand all | Expand 10 after
1631 // This should only be called when response document is parsed asynchronously. 1631 // This should only be called when response document is parsed asynchronously.
1632 DCHECK(response_document_parser_); 1632 DCHECK(response_document_parser_);
1633 DCHECK(!response_document_parser_->IsParsing()); 1633 DCHECK(!response_document_parser_->IsParsing());
1634 1634
1635 // Do nothing if we are called from |internalAbort()|. 1635 // Do nothing if we are called from |internalAbort()|.
1636 if (error_) 1636 if (error_)
1637 return; 1637 return;
1638 1638
1639 ClearVariablesForLoading(); 1639 ClearVariablesForLoading();
1640 1640
1641 response_document_->CheckCompleted();
1642
1643 if (!response_document_->WellFormed()) 1641 if (!response_document_->WellFormed())
1644 response_document_ = nullptr; 1642 response_document_ = nullptr;
1645 1643
1646 parsed_response_ = true; 1644 parsed_response_ = true;
1647 1645
1648 EndLoading(); 1646 EndLoading();
1649 } 1647 }
1650 1648
1651 void XMLHttpRequest::EndLoading() { 1649 void XMLHttpRequest::EndLoading() {
1652 probe::didFinishXHRLoading(GetExecutionContext(), this, this, method_, url_); 1650 probe::didFinishXHRLoading(GetExecutionContext(), this, this, method_, url_);
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
1891 visitor->TraceWrappers(response_document_); 1889 visitor->TraceWrappers(response_document_);
1892 visitor->TraceWrappers(response_array_buffer_); 1890 visitor->TraceWrappers(response_array_buffer_);
1893 XMLHttpRequestEventTarget::TraceWrappers(visitor); 1891 XMLHttpRequestEventTarget::TraceWrappers(visitor);
1894 } 1892 }
1895 1893
1896 std::ostream& operator<<(std::ostream& ostream, const XMLHttpRequest* xhr) { 1894 std::ostream& operator<<(std::ostream& ostream, const XMLHttpRequest* xhr) {
1897 return ostream << "XMLHttpRequest " << static_cast<const void*>(xhr); 1895 return ostream << "XMLHttpRequest " << static_cast<const void*>(xhr);
1898 } 1896 }
1899 1897
1900 } // namespace blink 1898 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698