Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2885623002: Revert "Refactor and clean up the status file parsing code." (Closed)

Created:
3 years, 7 months ago by Bob Nystrom
Modified:
3 years, 7 months ago
Reviewers:
Nate Bosch
CC:
reviews_dartlang.org, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Refactor and clean up the status file parsing code." This reverts commit 0b7728da1bef08c1c1e092005d9fd8c8bff5fa6c. R=nbosch@google.com Committed: https://github.com/dart-lang/sdk/commit/01e5b1b40c7886b5525ca98340977f8c59184958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+756 lines, -806 lines) Patch
M tests/co19/co19-dart2js.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -1 line 0 comments Download
D tools/testing/dart/expectation.dart View 1 chunk +0 lines, -211 lines 0 comments Download
D tools/testing/dart/expectation_set.dart View 1 chunk +0 lines, -118 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/status_expression.dart View 1 chunk +248 lines, -167 lines 0 comments Download
D tools/testing/dart/status_file.dart View 1 chunk +0 lines, -164 lines 0 comments Download
A tools/testing/dart/status_file_parser.dart View 1 chunk +368 lines, -0 lines 0 comments Download
M tools/testing/dart/summary_report.dart View 2 chunks +10 lines, -9 lines 0 comments Download
M tools/testing/dart/test_progress.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 27 chunks +96 lines, -98 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 12 chunks +27 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 7 months ago (2017-05-15 22:56:14 UTC) #2
Nate Bosch
lgtm
3 years, 7 months ago (2017-05-15 22:57:42 UTC) #3
Bob Nystrom
3 years, 7 months ago (2017-05-15 22:58:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
01e5b1b40c7886b5525ca98340977f8c59184958 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698