Issue 2885473002: Minor clean-up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2885473002: Minor clean-up (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson

Modified:
3 years, 7 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart	View		1 chunk	+3 lines, -7 lines	0 comments	Download
	M	pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

I noticed a couple of unused parameters while looking at how completion requests are currently ...

3 years, 7 months ago (2017-05-15 17:03:58 UTC) #2

Brian Wilkerson

3 years, 7 months ago (2017-05-15 17:09:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6643349a8fb16fffe463020d4fee8d5e23400679 (presubmit successful).