NavigationSimulator: add support for GlobalRequestIds

content/test/test_navigation_url_loader.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/test_navigation_url_loader.h"
 
 #include <utility>
 
 #include "content/browser/loader/navigation_url_loader_delegate.h"
 #include "content/public/browser/global_request_id.h"
 #include "content/public/browser/navigation_data.h"
+#include "content/public/browser/render_process_host.h"
 #include "content/public/browser/ssl_status.h"
 #include "content/public/browser/stream_handle.h"
+#include "content/public/browser/web_contents.h"
 #include "content/public/common/resource_response.h"
 #include "net/url_request/redirect_info.h"
 
 namespace content {
 
 TestNavigationURLLoader::TestNavigationURLLoader(
     std::unique_ptr<NavigationRequestInfo> request_info,
     NavigationURLLoaderDelegate* delegate)
     : request_info_(std::move(request_info)),
       delegate_(delegate),
@@ skipping 25 matching lines @@
 void TestNavigationURLLoader::CallOnRequestRedirected(
     const net::RedirectInfo& redirect_info,
     const scoped_refptr<ResourceResponse>& response) {
   delegate_->OnRequestRedirected(redirect_info, response);
 }
 
 void TestNavigationURLLoader::CallOnResponseStarted(
     const scoped_refptr<ResourceResponse>& response,
     std::unique_ptr<StreamHandle> body,
     std::unique_ptr<NavigationData> navigation_data) {
+  static int request_id = 0;

[Charlie Reis, 2017/05/15 20:07:43]

Hmm, now it does look like there's a potential for collisions.  Is it ever
possible for both NavigationSimulator and TestNavigationURLLoader to be used in
the same test?

[Charlie Harrison, 2017/05/15 21:45:54]

Yes, but the code I've changed in navigation_simulator will only run in
non-PlzNavigate world, and NavigationURLLoader is PlzNavigate only.

I've added a DCHECK in navigation_simulator so this is explicit.

[Charlie Reis, 2017/05/15 22:02:39]

Ah, glad they're mutually exclusive.  Can you add a similar DCHECK here that
PlzNavigate is enabled?  I don't see anything in this class except a comment on
the class declaration.

[Charlie Harrison, 2017/05/16 03:41:42]

I've added a DCHECK in the constructor.

+  int child_id =
+      WebContents::FromFrameTreeNodeId(request_info_->frame_tree_node_id)
+          ->GetRenderProcessHost()
+          ->GetID();
+  GlobalRequestID global_id(child_id, ++request_id);
   delegate_->OnResponseStarted(
       response, std::move(body), mojo::ScopedDataPipeConsumerHandle(),
-      SSLStatus(), std::move(navigation_data), GlobalRequestID(), false, false);
+      SSLStatus(), std::move(navigation_data), global_id, false, false);
 }
 
 TestNavigationURLLoader::~TestNavigationURLLoader() {}
 
 }  // namespace content