chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc - Issue 2885433003: VR: Implement Omnibox input targeting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc

Issue 2885433003: VR: Implement Omnibox input targeting. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/textures/url_bar_texture.h » ('j') | chrome/browser/android/vr_shell/textures/url_bar_texture.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc

diff --git a/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc b/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc

index d0745d2094b5ccd818c468c7d92169c7cfff5e8f..2fcf2f2e5990108597bc2ce2a9a420d36a8aaf3d 100644

--- a/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc

+++ b/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc

@@ -15,7 +15,7 @@ namespace {

static constexpr SkColor kBackground = 0xCCAAAAAA;

cjgrant 2017/05/16 14:07:23 Lets set these too? background: B9B9B9 foreground:

mthiesse 2017/05/16 18:11:01 I want to leave as-is for now. Will revisit once w

static constexpr SkColor kForeground = 0xCC444444;

-static constexpr float kWidth = 0.268;

+static constexpr float kWidth = 0.24;

static constexpr float kHeight = 0.008;

} // namespace

« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/textures/url_bar_texture.h » ('j') | chrome/browser/android/vr_shell/textures/url_bar_texture.h » ('J')