VR: Implement Omnibox input targeting.

chrome/browser/android/vr_shell/ui_scene_manager.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/ui_scene_manager.h"
 
 #include "base/callback.h"
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/android/vr_shell/textures/ui_texture.h"
 #include "chrome/browser/android/vr_shell/ui_elements/close_button.h"
@@ skipping 11 matching lines @@
 namespace {
 
 static constexpr int kWarningTimeoutSeconds = 30;
 static constexpr float kWarningDistance = 0.7;
 static constexpr float kWarningAngleRadians = 16.3 * M_PI / 180.0;
 static constexpr float kPermanentWarningHeight = 0.070f;
 static constexpr float kPermanentWarningWidth = 0.224f;
 static constexpr float kTransientWarningHeight = 0.160;
 static constexpr float kTransientWarningWidth = 0.512;
 
-static constexpr float kContentWidth = 2.4;
-static constexpr float kContentHeight = 1.6;
 static constexpr float kContentDistance = 2.5;
-static constexpr float kContentVerticalOffset = -0.26;
+static constexpr float kContentWidth = 0.96 * kContentDistance;
+static constexpr float kContentHeight = 0.64 * kContentDistance;
+static constexpr float kContentVerticalOffset = -0.1 * kContentDistance;
 static constexpr float kBackplaneSize = 1000.0;
 static constexpr float kBackgroundDistanceMultiplier = 1.414;
 
+static constexpr float kUrlBarDistance = 2.4;

[cjgrant, 2017/05/16 14:07:23]

Not in this CL, but what do you think of Josh's approach to this?  For each
element, there'd be a parent element, and we'd be doing something like:

urlBar.set_translation(0, -0.516, -1);
urlBarParent.set_scale(kUrlBarDistance, kUrlBarDistance, kUrlBarDistance);

And at the same time, we refactor the actual element class to set its own size
based on texture dimensions.  I'm not sure I like that approach, but it does
keep dimensions in one spot, and matches the way the spec describes things.

[mthiesse, 2017/05/16 18:11:02]

For now I'd like to land as-is, we have some thinking and discussing to do here.
For one, the scene manager needs to know size in order to set position
correctly, or we need to somehow allow elements to update their position based
on their size which could get complex quickly if we're not careful.

+static constexpr float kUrlBarWidth = 0.672 * kUrlBarDistance;
+static constexpr float kUrlBarHeight = 0.088 * kUrlBarDistance;
+static constexpr float kUrlBarVerticalOffset = -0.516 * kUrlBarDistance;
+
+static constexpr float kLoadingIndicatorWidth = 0.24 * kUrlBarDistance;
+static constexpr float kLoadingIndicatorHeight = 0.008 * kUrlBarDistance;
+static constexpr float kLoadingIndicatorOffset = -0.020 * kUrlBarDistance;

[cjgrant, 2017/05/16 14:07:23]

Worth it to do (0.016 + kLoadingIndicatorHeight / 2)) * kUrlBarDistance instead?

[mthiesse, 2017/05/16 18:11:02]

Done.

+
 static constexpr float kFullscreenWidth = 2.88;
 static constexpr float kFullscreenHeight = 1.62;
 static constexpr float kFullscreenDistance = 3;
 static constexpr float kFullscreenVerticalOffset = -0.26;
 static constexpr vr::Colorf kFullscreenBackgroundColor = {0.1, 0.1, 0.1, 1.0};
 
 static constexpr float kSceneSize = 25.0;
 static constexpr float kSceneHeight = 4.0;
 static constexpr int kFloorGridlineCount = 40;
 static constexpr vr::Colorf kBackgroundHorizonColor = {0.57, 0.57, 0.57, 1.0};
@@ skipping 134 matching lines @@
   control_elements_.push_back(element.get());
   scene_->AddUiElement(std::move(element));
 
   scene_->SetBackgroundColor(kBackgroundHorizonColor);
 }
 
 void UiSceneManager::CreateUrlBar() {
   // TODO(cjgrant): Incorporate final size and position.
   auto url_bar = base::MakeUnique<UrlBar>(512);
   url_bar->set_id(AllocateId());
-  url_bar->set_translation({0, -0.9, -1.8});
-  url_bar->set_size({0.9, 0, 1});
+  url_bar->set_translation({0, kUrlBarVerticalOffset, -kUrlBarDistance});
+  url_bar->set_size({kUrlBarWidth, kUrlBarHeight, 1});
   url_bar->SetBackButtonCallback(
       base::Bind(&UiSceneManager::OnBackButtonClicked, base::Unretained(this)));
   url_bar_ = url_bar.get();
   control_elements_.push_back(url_bar.get());
   scene_->AddUiElement(std::move(url_bar));
 
   auto indicator = base::MakeUnique<LoadingIndicator>(256);
   indicator->set_id(AllocateId());
-  indicator->set_translation({0, -0.8, -1.8});
-  indicator->set_size({0.4, 0, 1});
+  indicator->set_translation({0, 0, kLoadingIndicatorOffset});
+  indicator->set_size({kLoadingIndicatorWidth, kLoadingIndicatorHeight, 1});
+  indicator->set_parent_id(url_bar_->id());
+  indicator->set_y_anchoring(YAnchoring::YTOP);
   loading_indicator_ = indicator.get();
   control_elements_.push_back(indicator.get());
   scene_->AddUiElement(std::move(indicator));
 }
 
 void UiSceneManager::CreateCloseButton() {
   std::unique_ptr<CloseButton> element =
       base::MakeUnique<CloseButton>(base::Bind(
           &UiSceneManager::OnCloseButtonClicked, base::Unretained(this)));
   element->set_id(AllocateId());
@@ skipping 109 matching lines @@
 void UiSceneManager::SetHistoryButtonsEnabled(bool can_go_back,
                                               bool can_go_forward) {}
 
 void UiSceneManager::OnCloseButtonClicked() {}
 
 int UiSceneManager::AllocateId() {
   return next_available_id_++;
 }
 
 }  // namespace vr_shell