VR: Implement Omnibox input targeting.

chrome/browser/android/vr_shell/textures/url_bar_texture.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/textures/url_bar_texture.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "cc/paint/skia_paint_canvas.h"
 #include "components/security_state/core/security_state.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/font.h"
 #include "ui/gfx/font_list.h"
+#include "ui/gfx/geometry/point_f.h"
 #include "ui/gfx/geometry/rect.h"
+#include "ui/gfx/geometry/rect_f.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/gfx/render_text.h"
 #include "ui/gfx/vector_icon_types.h"
 #include "ui/vector_icons/vector_icons.h"
 
 namespace vr_shell {
 
 namespace {
 
-static constexpr SkColor kBackground = 0xCCAAAAAA;
-static constexpr SkColor kBackgroundHover = 0xCCDDDDDD;
+static constexpr SkColor kBackground = 0xCCD6D6D6;

[cjgrant, 2017/05/16 14:07:23]

Where is this one from?

[mthiesse, 2017/05/16 18:11:02]

I pulled it out of my a-

There wasn't any in the spec (well, there was but it was a weird blue color that
must have been erroneous), so I took the delta between the hover and down states
and set the background to have the same delta.

+static constexpr SkColor kBackgroundHover = 0xCCE1E1E1;

[cjgrant, 2017/05/16 14:07:23]

Should we drop the 0xCC?

[mthiesse, 2017/05/16 18:11:01]

Spec maaaaybe suggests using 0x66. so I'll switch to that.

+static constexpr SkColor kBackgroundDown = 0xCCECECEC;
 static constexpr SkColor kForeground = 0xCC444444;
 static constexpr SkColor kSeparatorColor =
     SkColorSetARGBMacro(256 * 0.2, 0, 0, 0);
 

[cjgrant, 2017/05/16 14:07:23]

We also have to add "inactive back button" coloring (either here or I'll do it
later)

[mthiesse, 2017/05/16 18:11:01]

l8r

 static constexpr float kWidth = 0.672;
 static constexpr float kHeight = 0.088;
 static constexpr float kFontHeight = 0.027;
 static constexpr float kBackButtonWidth = kHeight;
 static constexpr float kBackIconHeight = 0.05;
 static constexpr float kBackIconOffset = 0.005;
 static constexpr float kSecurityFieldWidth = 0.06;
 static constexpr float kSecurityIconHeight = 0.03;
 static constexpr float kUrlRightMargin = 0.02;
 static constexpr float kSeparatorWidth = 0.002;
+static constexpr float kBackHitTargetSize = 0.128;
 
 using security_state::SecurityLevel;
 
 const struct gfx::VectorIcon& getSecurityIcon(int level) {
   switch (level) {
     case SecurityLevel::NONE:
     case SecurityLevel::HTTP_SHOW_WARNING:
     case SecurityLevel::SECURITY_WARNING:
       return ui::kInfoOutlineIcon;
     case SecurityLevel::SECURE:
@@ skipping 21 matching lines @@
 void UrlBarTexture::SetSecurityLevel(int level) {
   if (&getSecurityIcon(security_level_) != &getSecurityIcon(level))
     set_dirty();
   security_level_ = level;
 }
 
 float UrlBarTexture::ToPixels(float meters) const {
   return meters * size_.width() / kWidth;
 }
 
+bool UrlBarTexture::HitsBackButton(const gfx::PointF& position) const {
+  float margin = (kBackHitTargetSize - kBackButtonWidth) / 2;
+  gfx::RectF rect(-margin, -margin, kBackHitTargetSize, kBackHitTargetSize);
+  rect.Scale(1.0f / (kWidth - kBackButtonWidth), 1.0f / kBackButtonWidth);
+  return rect.Contains(position);
+}
+
+bool UrlBarTexture::HitsURLBar(const gfx::PointF& position) const {
+  gfx::RectF rect(0, 0, 1, 1);
+  return rect.Contains(position) && !HitsRightTransparentRegion(position);
+}
+
+bool UrlBarTexture::HitsRightTransparentRegion(
+    const gfx::PointF& position) const {
+  float rounded_radius = kHeight / kWidth / 2;

[cjgrant, 2017/05/16 14:07:23]

This is fine if it works, but alternatively, would you find this more clear?

position = PercentageToMeters(position);
circle_center = {width - height/2, height/2}
if (position < circle_center.x())
  return false;
diff = position - circle_center;
return diff.LengthSquared() < height/2;

[mthiesse, 2017/05/16 18:11:01]

Yeah, looks clearer when you convert everything to meters, rather than
converting everything to percentages.

[cjgrant, 2017/05/16 18:22:21]

Acknowledged.

+  if (position.x() < 1.0f - rounded_radius)
+    return false;
+  float x = (position.x() - (1.0f - rounded_radius)) / rounded_radius / 2 + 0.5;
+  gfx::Vector2dF diff = gfx::PointF(x, position.y()) - gfx::PointF(0.5, 0.5);
+  return diff.LengthSquared() > 0.25;
+}
+
 void UrlBarTexture::Draw(SkCanvas* canvas, const gfx::Size& texture_size) {
   size_.set_height(texture_size.height());
   size_.set_width(texture_size.width());
 
   canvas->save();
   canvas->scale(size_.width() / kWidth, size_.width() / kWidth);
 
   // Make a gfx canvas to support utility drawing methods.
   cc::SkiaPaintCanvas paint_canvas(canvas);
   gfx::Canvas gfx_canvas(&paint_canvas, 1.0f);
 
   // Back button area.
   SkRRect round_rect;
   SkVector rounded_corner = {kHeight / 2, kHeight / 2};
   SkVector left_corners[4] = {rounded_corner, {0, 0}, {0, 0}, rounded_corner};
   round_rect.setRectRadii({0, 0, kHeight, kHeight}, left_corners);
+  SkColor color =
+      (GetDrawFlags() & FLAG_BACK_HOVER) ? kBackgroundHover : kBackground;
+  color = (GetDrawFlags() & FLAG_BACK_DOWN) ? kBackgroundDown : color;
   SkPaint paint;
-  paint.setColor((GetDrawFlags() & FLAG_HOVER) ? kBackgroundHover
-                                               : kBackground);
+  paint.setColor(color);
   canvas->drawRRect(round_rect, paint);
 
   // URL area.
   paint.setColor(kBackground);
   SkVector right_corners[4] = {{0, 0}, rounded_corner, rounded_corner, {0, 0}};
   round_rect.setRectRadii({kHeight, 0, kWidth, kHeight}, right_corners);
   canvas->drawRRect(round_rect, paint);
 
   // Back button / URL separator vertical line.
   paint.setColor(kSeparatorColor);
@@ skipping 55 matching lines @@
   return size_;
 }
 
 bool UrlBarTexture::SetDrawFlags(int draw_flags) {
   if (draw_flags != GetDrawFlags())
     set_dirty();
   return UiTexture::SetDrawFlags(draw_flags);
 }
 
 }  // namespace vr_shell