Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/tsan.supp

Issue 288533002: Update TSAN suppressions. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/tsan.supp
diff --git a/tools/tsan.supp b/tools/tsan.supp
index 8d97964f60dbf848cc07b914e1fe3258a150082b..d87f48609f93b161f97319502809eb7262b4e245 100644
--- a/tools/tsan.supp
+++ b/tools/tsan.supp
@@ -4,4 +4,9 @@
race:third_party/externals/libwebp
# skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers.
-race:swrast_dri.so # If this doesn't work, it's got to be SkGLContextHelper::init :(
+race:SkGLContextHelper::init # We don't always get swrast_dri.so in the stack or we'd use that.
+
+# For now assume anything using SkOnce and calls on SkRefCntBase (ref, unref, unique) are safe.
+# TODO(mtklein): teach TSAN about SkOnce, SkRefCnt and SkSpinlock correctly.
+race:SkOnce
+race:SkRefCntBase
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698