Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Issue 2885183002: DevTools: Make sure non-collapsible flamechart groups are treated as expanded. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
index 6e34f013edfbdd148a698a20c6251a2ce898c7fa..21a236dd37f7658b13650ef8495a170a08772f66 100644
--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
@@ -1127,8 +1127,9 @@ PerfUI.FlameChart = class extends PerfUI.ChartViewport {
if (groupIndex >= 0) {
var group = groups[groupIndex];
var style = group.style;
- height = isFirstOnLevel && !style.shareHeaderLine || !group.expanded ? style.height :
- (style.itemsHeight || this._barHeight);
+ height = isFirstOnLevel && !style.shareHeaderLine || (style.collapsible && !group.expanded) ?
+ style.height :
+ (style.itemsHeight || this._barHeight);
} else {
height = this._barHeight;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698