Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: telemetry/telemetry/story/expectations_unittest.py

Issue 2885173004: [Telemetry] Rename DisableBenchmark to PermenantlyDisableBenchmark in StoryExpectations (Closed)
Patch Set: add more documentation Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/story/expectations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/story/expectations_unittest.py
diff --git a/telemetry/telemetry/story/expectations_unittest.py b/telemetry/telemetry/story/expectations_unittest.py
index 00eec143cddefe40cc7a40a924829985e7f5c603..0963b5e4e607cd1bd412daacf33a955b657a627e 100644
--- a/telemetry/telemetry/story/expectations_unittest.py
+++ b/telemetry/telemetry/story/expectations_unittest.py
@@ -94,14 +94,15 @@ class StoryExpectationsTest(unittest.TestCase):
def testCantDisableAfterInit(self):
e = expectations.StoryExpectations()
with self.assertRaises(AssertionError):
- e.DisableBenchmark(['test'], 'test')
+ e.PermanentlyDisableBenchmark(['test'], 'test')
with self.assertRaises(AssertionError):
e.DisableStory('story', ['platform'], 'reason')
- def testDisableBenchmark(self):
+ def testPermanentlyDisableBenchmark(self):
class FooExpectations(expectations.StoryExpectations):
def SetExpectations(self):
- self.DisableBenchmark([expectations.ALL_WIN], 'crbug.com/123')
+ self.PermanentlyDisableBenchmark(
+ [expectations.ALL_WIN], 'crbug.com/123')
e = FooExpectations()
self.platform.SetOSName('win')
« no previous file with comments | « telemetry/telemetry/story/expectations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698