Show feedback button on sad tab if sad tab has shown recently.

chrome/browser/ui/sad_tab.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sad_tab.h"
 
 #include "base/metrics/histogram_macros.h"
+#include "base/time/time.h"
 #include "chrome/browser/net/referrer.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/feedback/feedback_util.h"
 #include "components/strings/grit/components_strings.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 34 matching lines @@
   } else {
     UMA_HISTOGRAM_ENUMERATION("Tabs.SadTab.Reload.Event", event,
                               SadTabEvent::MAX_SAD_TAB_EVENT);
   }
 }
 
 constexpr char kCategoryTagCrash[] = "Crash";
 
 bool ShouldShowFeedbackButton() {
 #if defined(GOOGLE_CHROME_BUILD)
-  const int kCrashesBeforeFeedbackIsDisplayed = 1;
+  const int kMinSecondsBetweenCrashesForFeedbackButton = 10;
 
-  static int total_crashes = 0;
-  return ++total_crashes > kCrashesBeforeFeedbackIsDisplayed;
+  static base::TimeTicks last_called = base::TimeTicks::UnixEpoch();

[Will Harris, 2017/05/18 00:58:08]

static initalizer for this class is allowed?

[sky, 2017/05/18 16:37:58]

Not sure on that, Nico likely knows.

[Nico, 2017/05/18 16:54:58]

This is a function level static. Despite the similar name, these don't need a
static initializers (which runs before main). Instead, it gets initialized the
first time this function runs. (The compiler emits a hidden global bool to store
if it's been initialized yet)

[Will Harris, 2017/05/18 22:59:47]

Acknowledged. Changed to store the int64_t static instead.

+
+  bool should_show = (base::TimeTicks().Now() - last_called).InSeconds() <
+                     kMinSecondsBetweenCrashesForFeedbackButton;
+
+  last_called = base::TimeTicks().Now();
+  return should_show;
 #else
   return false;
 #endif
 }
 
 }  // namespace
 
 namespace chrome {
 
 // static
@@ skipping 130 matching lines @@
     // Fall through
     case chrome::SAD_TAB_KIND_KILLED:
       UMA_SAD_TAB_COUNTER("Tabs.SadTab.KillCreated");
       LOG(WARNING) << "Tab Killed: "
                    << web_contents->GetURL().GetOrigin().spec();
       break;
   }
 }
 
 }  // namespace chrome