icu: Add defines for Fuchsia

icu: Add defines for Fuchsia

Without a Linux-ish define for Fuchsia, neither U_WCHAR_IS_UTF16 nor
U_WCHAR_IS_UTF32 are defined, resulting in warnings in ICU code when
compiled on Fuchsia. Filed upstream at
http://www.icu-project.org/trac/ticket/13202.

BUG=706592
R=jshin@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/c844075aa0f1758d04f9192825f1b1e7e607992e

[scottmg, 2017-05-17 22:46:38]

Description was changed from

==========
icu: Add defines for Fuchsia

Without a Linux-ish define for Fuchsia, neither U_WCHAR_IS_UTF16 nor
U_WCHAR_IS_UTF32 are defined, resulting in warnings in ICU code when
compiled on Fuchsia. Filed upstream at
http://www.icu-project.org/trac/ticket/13202.

BUG=706592
==========

to

==========
icu: Add defines for Fuchsia

Without a Linux-ish define for Fuchsia, neither U_WCHAR_IS_UTF16 nor
U_WCHAR_IS_UTF32 are defined, resulting in warnings in ICU code when
compiled on Fuchsia. Filed upstream at
http://www.icu-project.org/trac/ticket/13202.

BUG=706592
==========

[scottmg, 2017-05-17 22:46:38]

scottmg@chromium.org changed reviewers:
+ jshin@chromium.org

[jungshik at Google, 2017-05-18 00:19:35]

LGTM.

Thanks

https://codereview.chromium.org/2885143008/diff/1/patches/fuchsia.patch
File patches/fuchsia.patch (right):

https://codereview.chromium.org/2885143008/diff/1/patches/fuchsia.patch#newcode9
patches/fuchsia.patch:9: +/** Fuchsia is a POSIX-ish platform. @internal */
Glad to know that. :-) 
I was wondering about Fuchsia and ICU for a while, but haven't managed to
contact the team. (I was worried that a lot more extensive changes might be
necessary for fuchsia. ) 

Thanks for the CL.

[scottmg, 2017-05-18 00:21:01]

On 2017/05/18 00:19:35, jungshik at Google wrote:
> LGTM.
> 
> Thanks
> 
> https://codereview.chromium.org/2885143008/diff/1/patches/fuchsia.patch
> File patches/fuchsia.patch (right):
> 
>
https://codereview.chromium.org/2885143008/diff/1/patches/fuchsia.patch#newcode9
> patches/fuchsia.patch:9: +/** Fuchsia is a POSIX-ish platform. @internal */
> Glad to know that. :-) 
> I was wondering about Fuchsia and ICU for a while, but haven't managed to
> contact the team. (I was worried that a lot more extensive changes might be
> necessary for fuchsia. ) 
> 
> Thanks for the CL.

Thanks for the quick review. I'm not 100% certain that this is sufficient yet as
I haven't got base_unittests all working yet, but I don't believe there will be
any major changes required.

[scottmg, 2017-05-18 00:27:45]

Description was changed from

==========
icu: Add defines for Fuchsia

Without a Linux-ish define for Fuchsia, neither U_WCHAR_IS_UTF16 nor
U_WCHAR_IS_UTF32 are defined, resulting in warnings in ICU code when
compiled on Fuchsia. Filed upstream at
http://www.icu-project.org/trac/ticket/13202.

BUG=706592
==========

to

==========
icu: Add defines for Fuchsia

Without a Linux-ish define for Fuchsia, neither U_WCHAR_IS_UTF16 nor
U_WCHAR_IS_UTF32 are defined, resulting in warnings in ICU code when
compiled on Fuchsia. Filed upstream at
http://www.icu-project.org/trac/ticket/13202.

BUG=706592
R=jshin@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/icu/+/c844075aa0f1758d04f9192...
==========

[scottmg, 2017-05-18 00:27:46]

Committed patchset #1 (id:1) manually as
c844075aa0f1758d04f9192825f1b1e7e607992e (presubmit successful).