Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 288513002: Files.app: Specify a test case name to the test system. (Closed)

Created:
6 years, 7 months ago by hirono
Modified:
6 years, 7 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, yoshiki+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Files.app: Specify a test case name to the test system. Previously the test system cannot obtain the name of test cases because they are anonymous inline functions. And it causes a log like "[SUCCESS] undefined". BUG=372683 TEST=run the tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/test/data/extensions/api_test/file_manager_browsertest/background.js View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 7 months ago (2014-05-13 06:26:20 UTC) #1
mtomasz
Cool! LGTM
6 years, 7 months ago (2014-05-13 06:28:56 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 7 months ago (2014-05-13 06:32:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/288513002/1
6 years, 7 months ago (2014-05-13 06:32:55 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 09:20:46 UTC) #5
Message was sent while issue was closed.
Change committed as 270058

Powered by Google App Engine
This is Rietveld 408576698