Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Issue 2885103005: Add dart:html and friends to patched_dart2js_sdk/platform.dill, also fix up (Closed)

Created:
3 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 7 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dart:html and friends to patched_dart2js_sdk/platform.dill, also fix up warnings on these libraries. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/cd2ebf70a2c51881ac6ffde2dbecc9fcbbdc5446

Patch Set 1 #

Total comments: 1

Patch Set 2 : v1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -29 lines) Patch
M pkg/compiler/lib/src/kernel/fasta_support.dart View 1 chunk +18 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/translate_uri.dart View 1 chunk +10 lines, -9 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/html/html_common/css_class_set.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
Stephen - let me know if you prefer that I land the library changes on ...
3 years, 7 months ago (2017-05-17 15:49:20 UTC) #2
sra1
lgtm
3 years, 7 months ago (2017-05-17 16:08:33 UTC) #3
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-05-17 17:58:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cd2ebf70a2c51881ac6ffde2dbecc9fcbbdc5446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698