Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: chrome/browser/android/vr_shell/vr_tab_helper.h

Issue 2885033007: Disable color/date chooser in VR mode via WebPreferences (Closed)
Patch Set: added explanatory comment. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/vr_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/vr_tab_helper.h
diff --git a/chrome/browser/android/vr_shell/vr_tab_helper.h b/chrome/browser/android/vr_shell/vr_tab_helper.h
index f14764ee3a764c53b190388226baf390561ad001..315ce623a5fe5b3e742173912c81e9cfb5313c9f 100644
--- a/chrome/browser/android/vr_shell/vr_tab_helper.h
+++ b/chrome/browser/android/vr_shell/vr_tab_helper.h
@@ -17,20 +17,17 @@ class VrTabHelper : public content::WebContentsUserData<VrTabHelper> {
bool is_in_vr() const { return is_in_vr_; }
// Called by VrShell when we enter and exit vr mode. It finds us by looking us
- // up on the WebContents. Eventually, we will also set a number of flags here
- // as we enter and exit vr mode (see TODO below).
+ // up on the WebContents.
void SetIsInVr(bool is_in_vr);
static bool IsInVr(content::WebContents* contents);
private:
- friend class content::WebContentsUserData<VrTabHelper>;
-
explicit VrTabHelper(content::WebContents* contents);
- // TODO(asimjour): once we have per-dialog flags for disabling specific
- // content-related popups, we should hang onto a pointer to the web contents
- // and set those flags as we enter and exit vr mode.
+ friend class content::WebContentsUserData<VrTabHelper>;
+
+ content::WebContents* web_contents_;
bool is_in_vr_ = false;
DISALLOW_COPY_AND_ASSIGN(VrTabHelper);
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/vr_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698