Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

Issue 2885013004: Remove unused histograms Omnibox.ProgressBar (Closed)
Patch Set: add bug link to obselete tag Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
index 3de9e74c3fa6716c046d67a8fa010c43720ca426..e1e931929e6f70d18e00839a45703b5579275140 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
@@ -19,7 +19,6 @@ import android.widget.ProgressBar;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.CommandLine;
import org.chromium.base.VisibleForTesting;
-import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.util.ColorUtils;
@@ -33,10 +32,6 @@ import org.chromium.ui.interpolators.BakedBezierInterpolator;
public class ToolbarProgressBar extends ClipDrawableProgressBar {
private static final String ANIMATION_FIELD_TRIAL_NAME = "ProgressBarAnimationAndroid";
- private static final String PROGRESS_BAR_UPDATE_COUNT_HISTOGRAM =
- "Omnibox.ProgressBarUpdateCount";
- private static final String PROGRESS_BAR_BREAK_POINT_UPDATE_COUNT_HISTOGRAM =
- "Omnibox.ProgressBarBreakPointUpdateCount";
/**
* Interface for progress bar animation interpolation logics.
@@ -72,7 +67,6 @@ public class ToolbarProgressBar extends ClipDrawableProgressBar {
private boolean mIsStarted;
private float mTargetProgress;
- private int mTargetProgressUpdateCount;
private AnimationLogic mAnimationLogic;
private boolean mAnimationInitialized;
private int mMarginTop;
@@ -262,8 +256,6 @@ public class ToolbarProgressBar extends ClipDrawableProgressBar {
}
mIsRunningSmoothIndeterminate = false;
- mTargetProgressUpdateCount = 0;
- resetProgressUpdateCount();
super.setProgress(0.0f);
if (mAnimationLogic != null) mAnimationLogic.reset(0.0f);
removeCallbacks(mHideRunnable);
@@ -286,11 +278,6 @@ public class ToolbarProgressBar extends ClipDrawableProgressBar {
if (delayed) {
updateVisibleProgress();
- RecordHistogram.recordCount1000Histogram(PROGRESS_BAR_UPDATE_COUNT_HISTOGRAM,
- getProgressUpdateCount());
- RecordHistogram.recordCount100Histogram(
- PROGRESS_BAR_BREAK_POINT_UPDATE_COUNT_HISTOGRAM,
- mTargetProgressUpdateCount);
} else {
removeCallbacks(mHideRunnable);
animate().cancel();
@@ -386,7 +373,6 @@ public class ToolbarProgressBar extends ClipDrawableProgressBar {
}
}
- mTargetProgressUpdateCount += 1;
mTargetProgress = progress;
updateVisibleProgress();
}

Powered by Google App Engine
This is Rietveld 408576698