third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-ray.html - Issue 2884943002: CSS Motion Path: calculate transform for simple ray() paths

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-ray.html

Issue 2884943002: CSS Motion Path: calculate transform for simple ray() paths (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt/css/motion-1/offset-path-ray-ref.html » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>CSS Motion Path: ray paths</title>

	5 <link rel="author" title="Eric Willigers" href="mailto:ericwilligers@google. com">

	6 <link rel="help" href="https://drafts.fxtf.org/motion-1/#offset-path-propert y">

	7 <link rel="match" href="offset-path-ray-ref.html">

	8 <meta name="assert" content="This tests that ray() generates a rotation and translation.">

	9 <style>

	10 #target {

	11 position: absolute;
	pdr. 2017/05/16 22:51:19 Do these have to be position: absolute? Do these have to be position: absolute? Eric Willigers 2017/05/17 05:47:00 left and top only have effect on positioned elemen Show quoted text On 2017/05/16 22:51:19, pdr. wrote: > Do these have to be position: absolute? left and top only have effect on positioned elements. https://developer.mozilla.org/en/docs/Web/CSS/left We could omit position: absolute and left and top, but then the elements would be partially rotated off the screen.
	12 left: 300px;

	13 top: 100px;

	14 width: 300px;

	15 height: 200px;

	16 background-color: lime;

	17 transform-origin: 0px 0px;

	18 offset-path: ray(150deg closest-side);
	pdr. 2017/05/16 22:51:19 Naive question: when I try the examples from the s Naive question: when I try the examples from the spec such as example 6 with the circles, they don't work. For example, http://jsbin.com/xorofav. Is there something I'm missing, or is this just lack of <size> support? Eric Willigers 2017/05/17 05:47:00 There are three issues. 1. The circles appear bel Show quoted text On 2017/05/16 22:51:19, pdr. wrote: > Naive question: when I try the examples from the spec such as example 6 with the > circles, they don't work. For example, http://jsbin.com/xorofav. Is there > something I'm missing, or is this just lack of <size> support? There are three issues. 1. The circles appear below each other because of block layout. The example should have .circleElement { position: absolute; left: 50%; top: 50%; } and body { transform-style: preserve-3d; } so that the elements are placed on rays from the body's center. 2. The offset-path values omit <size>, which is now required. 3. The example uses percentage offset-distance, which is yet to be implemented. For now, use px: https://jsbin.com/poseha I have created https://github.com/w3c/fxtf-drafts/pull/164 for the first two issues.
	19 offset-distance: 20px;

	20 }

	21 </style>

	22 </head>

	23 <body>

	24 <div id="target"></div>

	25 </body>

	26 </html>

OLD	NEW