Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: chrome/browser/profiles/profile_metrics.cc

Issue 288493008: UMA Metrics for the user menu, including vasquette-detection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change histogram bucket order for maintainability. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_metrics.cc
diff --git a/chrome/browser/profiles/profile_metrics.cc b/chrome/browser/profiles/profile_metrics.cc
index a829be238793e76afa1d163b7239a18873845578..670810557693db3f0f540d537045cc2212b3d959 100644
--- a/chrome/browser/profiles/profile_metrics.cc
+++ b/chrome/browser/profiles/profile_metrics.cc
@@ -295,6 +295,20 @@ void ProfileMetrics::LogProfileUpgradeEnrollment(
NUM_PROFILE_ENROLLMENT_METRICS);
}
+void ProfileMetrics::LogProfileDesktopSignout(ProfileDesktopSignout metric,
+ bool opened_from_content) {
+ // Only type of action be noted; whether Content-sourced or not is specified
+ // in |opened_from_content|
+ DCHECK(metric % 2 == 0);
Alexei Svitkine (slow) 2014/05/14 20:04:17 Nit: DCHECK_EQ?
Mike Lerman 2014/05/14 20:09:16 That would be better. Done.
+ // If opened from the content area, increment the metric to log that
+ // this was opened from the content.
+ if (opened_from_content) {
Alexei Svitkine (slow) 2014/05/14 20:04:17 Nit: No {}'s
Mike Lerman 2014/05/14 20:09:16 Done.
+ metric = static_cast<ProfileDesktopSignout>(metric + 1);
+ }
+ UMA_HISTOGRAM_ENUMERATION("Profile.DesktopSignout", metric,
+ NUM_PROFILE_DESKTOP_SIGNOUT_METRICS);
+}
+
void ProfileMetrics::LogProfileLaunch(Profile* profile) {
base::FilePath profile_path = profile->GetPath();
UMA_HISTOGRAM_ENUMERATION("Profile.LaunchBrowser",

Powered by Google App Engine
This is Rietveld 408576698