Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 288493008: UMA Metrics for the user menu, including vasquette-detection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit - make a member variable const Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 52f80244925bf80ecb624317a55812498c5af8e4..eca7011b46d90301da7cfe5e29dcf8136959be4a 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2380,10 +2380,18 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton(AvatarBubbleMode mode) {
views::View::ConvertPointToScreen(button, &origin);
gfx::Rect bounds(origin, size());
- ProfileChooserView::BubbleViewMode view_mode =
- (mode == BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT) ?
- ProfileChooserView::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT :
- ProfileChooserView::BUBBLE_VIEW_MODE_PROFILE_CHOOSER;
+ ProfileChooserView::BubbleViewMode view_mode;
+ switch (mode) {
+ case BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT:
+ view_mode = ProfileChooserView::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT;
+ break;
+ case BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT_FROM_HEADER:
+ view_mode =
+ ProfileChooserView::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT_FROM_HEADER;
+ break;
+ case BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT:
+ view_mode = ProfileChooserView::BUBBLE_VIEW_MODE_PROFILE_CHOOSER;
+ }
ProfileChooserView::ShowBubble(
view_mode, button, views::BubbleBorder::TOP_RIGHT,
views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE, bounds, browser());

Powered by Google App Engine
This is Rietveld 408576698