UMA Metrics for the user menu, including vasquette-detection

chrome/browser/profiles/profile_metrics.cc

Index: chrome/browser/profiles/profile_metrics.cc
diff --git a/chrome/browser/profiles/profile_metrics.cc b/chrome/browser/profiles/profile_metrics.cc
index a829be238793e76afa1d163b7239a18873845578..c5f428c7d5a53bbd768ae2d25ee8d7284b5c0419 100644
--- a/chrome/browser/profiles/profile_metrics.cc
+++ b/chrome/browser/profiles/profile_metrics.cc
@@ -295,6 +295,21 @@ void ProfileMetrics::LogProfileUpgradeEnrollment(
                             NUM_PROFILE_ENROLLMENT_METRICS);
 }
 
+void ProfileMetrics::LogProfileDesktopSignout(ProfileDesktopSignout metric,
+                                              bool opened_from_vasquette) {
+  // Only type of action be noted; whether Vasquette-sourced or not is specified
+  // in |opened_from_vasquette|
+  DCHECK(metric < FIRST_VASQUETTE_SIGNOUT_ENUM);
+  // If opened from the vasquette, increment the metric to log that
+  // this was opened from the vasquette.
+  if (opened_from_vasquette) {
+    metric = static_cast<ProfileDesktopSignout>(
+                 metric + FIRST_VASQUETTE_SIGNOUT_ENUM + 1);

[Alexei Svitkine (slow), 2014/05/14 14:15:22]

Instead of doing this funny business with a set of parallel enums, would it make
more sense to use a single enum and two different histograms?

e.g. Profile.DesktopSignout and Profile.DesktopSignout.Vasquette or something

[Mike Lerman, 2014/05/14 19:46:15]

Having the data points all in the same histogram will be very useful for
comparing data, so we can see proportionally how people are using the system
depending on which entry point they took.
I don't see any facility for combining/aggregating parallel histograms (that
vary only by suffix)... is there one?

[Alexei Svitkine (slow), 2014/05/14 19:55:04]

No, it's not possible to combine them into one. But if you make them have the
same suffix, e.g. Foo.Bar.Bazz and Foo.Bar.Buzz, then you can just enter
Foo.Bar.* into the histograms dashboard and it will show load all the matching
histograms.

+  }
+  UMA_HISTOGRAM_ENUMERATION("Profile.DesktopSignout", metric,
+                            NUM_PROFILE_DESKTOP_SIGNOUT_METRICS);
+}
+
 void ProfileMetrics::LogProfileLaunch(Profile* profile) {
   base::FilePath profile_path = profile->GetPath();
   UMA_HISTOGRAM_ENUMERATION("Profile.LaunchBrowser",