chrome/browser/signin/signin_global_error.cc - Issue 288493008: UMA Metrics for the user menu, including vasquette-detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_global_error.cc

Issue 288493008: UMA Metrics for the user menu, including vasquette-detection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/signin_global_error.cc

diff --git a/chrome/browser/signin/signin_global_error.cc b/chrome/browser/signin/signin_global_error.cc

index e0fa1a53e58536c5a231ec00eddcf01e4d6c2912..c5387eb891c868d13218f436fcd1b0ccc5f2a953 100644

--- a/chrome/browser/signin/signin_global_error.cc

+++ b/chrome/browser/signin/signin_global_error.cc

@@ -7,6 +7,7 @@

#include "base/logging.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/signin/signin_header_helper.h"

#include "chrome/browser/signin/signin_manager_factory.h"

#include "chrome/browser/signin/signin_promo.h"

#include "chrome/browser/ui/browser_commands.h"

@@ -99,7 +100,8 @@ void SigninGlobalError::ExecuteMenuItem(Browser* browser) {

if (switches::IsNewProfileManagement()) {

browser->window()->ShowAvatarBubbleFromAvatarButton(

- BrowserWindow::AVATAR_BUBBLE_MODE_REAUTH);

+ BrowserWindow::AVATAR_BUBBLE_MODE_REAUTH,

+ signin::GAIA_SERVICE_TYPE_NONE);

} else {

chrome::ShowSingletonTab(

browser,