Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2753)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 288493008: UMA Metrics for the user menu, including vasquette-detection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clear service type after profilechooser action. Rename default histogram. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index 07b60bf9ada8062b3c61df63620c1b06d23df556..2bc188e8eeb3cce6072444d514d34f05a9a56b9f 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -20,6 +20,7 @@
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/shell_integration.h"
+#include "chrome/browser/signin/signin_header_helper.h"
#include "chrome/browser/translate/translate_tab_helper.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_command_controller.h"
@@ -705,11 +706,13 @@ void BrowserWindowCocoa::ShowAvatarBubble(WebContents* web_contents,
}
void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(
- AvatarBubbleMode mode) {
+ AvatarBubbleMode mode, signin::GAIA_SERVICE_TYPE service_type) {
AvatarBaseController* controller = [controller_ avatarButtonController];
NSView* anchor = [controller buttonView];
if ([anchor isHiddenOrHasHiddenAncestor])
anchor = [[controller_ toolbarController] wrenchButton];
+ // TODO(mlerman): pass |service_type| to profile_chooser_controller to
+ // implement UMA instrumentation of the menu.
[controller showAvatarBubble:anchor withMode:mode];
}

Powered by Google App Engine
This is Rietveld 408576698