Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 288493008: UMA Metrics for the user menu, including vasquette-detection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split user-menu data based on GAIA service type Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index b2660777297636fe258033a1734041709a206a1e..3410ce6e44a04151b063404db33277e3ee873d08 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -30,6 +30,7 @@
#include "chrome/browser/sessions/tab_restore_service.h"
#include "chrome/browser/sessions/tab_restore_service_delegate.h"
#include "chrome/browser/sessions/tab_restore_service_factory.h"
+#include "chrome/browser/signin/signin_header_helper.h"
#include "chrome/browser/translate/translate_tab_helper.h"
#include "chrome/browser/ui/accelerator_utils.h"
#include "chrome/browser/ui/bookmarks/bookmark_utils.h"
@@ -735,7 +736,7 @@ void BookmarkCurrentPage(Browser* browser) {
case extensions::CommandService::PAGE_ACTION:
browser->window()->ShowPageActionPopup(extension);
return;
- };
+ }
}
BookmarkCurrentPageInternal(browser);
@@ -1041,7 +1042,8 @@ void ShowAppMenu(Browser* browser) {
void ShowAvatarMenu(Browser* browser) {
browser->window()->ShowAvatarBubbleFromAvatarButton(
- BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT);
+ BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT,
+ signin::GAIA_SERVICE_TYPE_NONE);
}
void OpenUpdateChromeDialog(Browser* browser) {

Powered by Google App Engine
This is Rietveld 408576698