Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 288493008: UMA Metrics for the user menu, including vasquette-detection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit - make a member variable const Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "chrome/browser/lifetime/browser_close_manager.h" 9 #include "chrome/browser/lifetime/browser_close_manager.h"
10 #include "chrome/browser/translate/translate_tab_helper.h" 10 #include "chrome/browser/translate/translate_tab_helper.h"
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 // Shows the avatar bubble inside |web_contents|. The bubble is positioned 360 // Shows the avatar bubble inside |web_contents|. The bubble is positioned
361 // relative to |rect|. |rect| should be in the |web_contents| coordinate 361 // relative to |rect|. |rect| should be in the |web_contents| coordinate
362 // system. 362 // system.
363 virtual void ShowAvatarBubble(content::WebContents* web_contents, 363 virtual void ShowAvatarBubble(content::WebContents* web_contents,
364 const gfx::Rect& rect) = 0; 364 const gfx::Rect& rect) = 0;
365 365
366 // Shows the avatar bubble on the window frame off of the avatar button with 366 // Shows the avatar bubble on the window frame off of the avatar button with
367 // the given mode. 367 // the given mode.
368 enum AvatarBubbleMode { 368 enum AvatarBubbleMode {
369 AVATAR_BUBBLE_MODE_DEFAULT, 369 AVATAR_BUBBLE_MODE_DEFAULT,
370 AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT 370 AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,
371 AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT_FROM_HEADER
Roger Tawa OOO till Jul 10th 2014/05/14 14:08:44 Nit: lets call this FROM_GAIA instead of FROM_HEAD
Mike Lerman 2014/05/14 19:46:15 Done.
371 }; 372 };
372 virtual void ShowAvatarBubbleFromAvatarButton(AvatarBubbleMode mode) = 0; 373 virtual void ShowAvatarBubbleFromAvatarButton(AvatarBubbleMode mode) = 0;
373 374
374 // Show bubble for password generation positioned relative to |rect|. The 375 // Show bubble for password generation positioned relative to |rect|. The
375 // subclasses implementing this interface do not own the |password_generator| 376 // subclasses implementing this interface do not own the |password_generator|
376 // object which is passed to generate the password. |form| is the form that 377 // object which is passed to generate the password. |form| is the form that
377 // contains the password field that the bubble will be associated with. 378 // contains the password field that the bubble will be associated with.
378 virtual void ShowPasswordGenerationBubble( 379 virtual void ShowPasswordGenerationBubble(
379 const gfx::Rect& rect, 380 const gfx::Rect& rect,
380 const autofill::PasswordForm& form, 381 const autofill::PasswordForm& form,
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 434
434 // Returns the ToolbarView. 435 // Returns the ToolbarView.
435 virtual ToolbarView* GetToolbarView() const = 0; 436 virtual ToolbarView* GetToolbarView() const = 0;
436 #endif 437 #endif
437 438
438 protected: 439 protected:
439 virtual ~BrowserWindowTesting() {} 440 virtual ~BrowserWindowTesting() {}
440 }; 441 };
441 442
442 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 443 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698