UMA Metrics for the user menu, including vasquette-detection

chrome/browser/profiles/profile_metrics.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
@@ skipping 78 matching lines @@
     PROFILE_ENROLLMENT_LAUNCH_LEARN_MORE,
     // User opted into New Profile Management via Promo card.
     PROFILE_ENROLLMENT_ACCEPT_NEW_PROFILE_MGMT,
     // User closed the Upgrade card.
     PROFILE_ENROLLMENT_CLOSE_WELCOME_CARD,
     // Used disabled New Profile Management.
     PROFILE_ENROLLMENT_DISABLE_NEW_PROFILE_MGMT,
     NUM_PROFILE_ENROLLMENT_METRICS,
   };
 
+  // Enum for tracking user interactions with the user menu and user manager,
+  // including tracking if the vasquette was the start for user interaction.

[Alexei Svitkine (slow), 2014/05/14 14:15:22]

What's a vasquette? It doesn't seem to be a real word (according to
define:vasquette in Google).

It would be good to clarify in this comment what this is (or better yet to
describe it in a way that is more clear rather than using this term).

[Mike Lerman, 2014/05/14 19:46:15]

I had thought Vasquette was a Google-wide term. Apparently not :) I'll change
the wording. Thanks!

+  // Note: The n items before |FIRST_VASQUETTE_SIGNOUT_ENUM| should parallel
+  // the n items between |FIRST_VASQUETTE_SIGNOUT_ENUM| and
+  // |NUM_PROFILE_DESKTOP_SIGNOUT_METRICS| to indicate whether the particular
+  // user action was initiated from the vasquette or the avatar button.
+  enum ProfileDesktopSignout {
+    // User opened the user menu directly, and clicked lock.
+    PROFILE_DESKTOP_MENU_LOCK,
+    // User opened the user menu directly, and switched profiles.
+    PROFILE_DESKTOP_MENU_SWITCH,
+    // User opened the user menu directly, and started removing an account.
+    PROFILE_DESKTOP_MENU_REMOVE_ACCT,
+    // User opened the user menu directly, and started adding an account.
+    PROFILE_DESKTOP_MENU_ADD_ACCT,
+    // |FIRST_VASQUETTE_SIGNOUT_ENUM| should always be the midpoint enum.

[Alexei Svitkine (slow), 2014/05/14 14:15:22]

How are you going to keep this condition true when adding new entries? Remember,
you can't renumber existing entries in an enum used for UMA.

[Mike Lerman, 2014/05/14 19:46:15]

I'll take a different approach to ordering these. This is a good point.

+    // This bucket of the histogram should always be empty.
+    FIRST_VASQUETTE_SIGNOUT_ENUM,
+    // User clicked on vasquette, went to the user menu, and clicked lock.
+    PROFILE_DESKTOP_VASQUETTE_MENU_LOCK,
+    // User clicked on vasquette, went to the user menu, and switched profiles.
+    PROFILE_DESKTOP_VASQUETTE_MENU_SWITCH,
+    // User clicked on vasquette, went to the user menu, and started removing an
+    // account.
+    PROFILE_DESKTOP_VASQUETTE_REMOVE_ACCT,
+    // User clicked on vasquette, went to the user menu, and started adding an
+    // account.
+    PROFILE_DESKTOP_VASQUETTE_ADD_ACCT,
+    NUM_PROFILE_DESKTOP_SIGNOUT_METRICS,
+  };
+
   static void UpdateReportedProfilesStatistics(ProfileManager* manager);
 
   static void LogNumberOfProfiles(ProfileManager* manager);
   static void LogProfileAddNewUser(ProfileAdd metric);
   static void LogProfileAvatarSelection(size_t icon_index);
   static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileOpenMethod(ProfileOpen metric);
   static void LogProfileSwitchGaia(ProfileGaia metric);
   static void LogProfileSwitchUser(ProfileOpen metric);
   static void LogProfileSyncInfo(ProfileSync metric);
   static void LogProfileAuthResult(ProfileAuth metric);
   static void LogProfileUpgradeEnrollment(ProfileUpgradeEnrollment metric);
+  static void LogProfileDesktopSignout(ProfileDesktopSignout metric,
+                                       bool opened_from_vasquette);
 
   // These functions should only be called on the UI thread because they hook
   // into g_browser_process through a helper function.
   static void LogProfileLaunch(Profile* profile);
   static void LogProfileSyncSignIn(const base::FilePath& profile_path);
   static void LogProfileUpdate(const base::FilePath& profile_path);
 };
 
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_