UMA Metrics for the user menu, including vasquette-detection

chrome/browser/profiles/profile_metrics.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
 #include "base/basictypes.h"
 
 class Profile;
 class ProfileManager;
 
 namespace base {
 class FilePath;
 }
 
+namespace signin {
+enum GAIA_SERVICE_TYPE;
+}
+
 class ProfileMetrics {
  public:
   // Enum for counting the ways users were added.
   enum ProfileAdd {
     ADD_NEW_USER_ICON = 0,    // User adds new user from icon menu
     ADD_NEW_USER_MENU,        // User adds new user from menu bar
     ADD_NEW_USER_DIALOG,      // User adds new user from create-profile dialog
     ADD_NEW_USER_MANAGER,     // User adds new user from User Manager
     NUM_PROFILE_ADD_METRICS
   };
@@ skipping 59 matching lines @@
     PROFILE_ENROLLMENT_LAUNCH_LEARN_MORE,
     // User opted into New Profile Management via Promo card.
     PROFILE_ENROLLMENT_ACCEPT_NEW_PROFILE_MGMT,
     // User closed the Upgrade card.
     PROFILE_ENROLLMENT_CLOSE_WELCOME_CARD,
     // Used disabled New Profile Management.
     PROFILE_ENROLLMENT_DISABLE_NEW_PROFILE_MGMT,
     NUM_PROFILE_ENROLLMENT_METRICS,
   };
 
+  // Enum for tracking user interactions with the user menu and user manager.
+  // Interactions initiated from the content area are logged into a different
+  // histogram from those that were initiated from the avatar button.
+  // An example of the interaction beginning in the content area is
+  // clicking "Manage Accounts" within account selection on a Google property.
+  enum ProfileDesktopMenu {
+    // User opened the user menu, and clicked lock.
+    PROFILE_DESKTOP_MENU_LOCK = 0,
+    // User opened the user menu, and started removing an account.

[guohui, 2014/05/22 20:20:49]

i think its more interesting to log the actual account removal than showing the
account removal view. Please also see my comment in profile_chooser_view.cc.

[Mike Lerman, 2014/05/23 17:15:36]

Done.

+    PROFILE_DESKTOP_MENU_REMOVE_ACCT,
+    // User opened the user menu, and started adding an account.
+    PROFILE_DESKTOP_MENU_ADD_ACCT,
+    NUM_PROFILE_DESKTOP_MENU_METRICS,
+  };

[guohui, 2014/05/22 20:20:49]

its also interesting to log clicking "not you" and clicking "settings" link to
disconnect the profile.

[Mike Lerman, 2014/05/23 17:15:36]

I'm planning to do so in a new CL. Should I add a TODO?

+
   static void UpdateReportedProfilesStatistics(ProfileManager* manager);
 
   static void LogNumberOfProfiles(ProfileManager* manager);
   static void LogProfileAddNewUser(ProfileAdd metric);
   static void LogProfileAvatarSelection(size_t icon_index);
   static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileOpenMethod(ProfileOpen metric);
   static void LogProfileSwitchGaia(ProfileGaia metric);
   static void LogProfileSwitchUser(ProfileOpen metric);
   static void LogProfileSyncInfo(ProfileSync metric);
   static void LogProfileAuthResult(ProfileAuth metric);
   static void LogProfileUpgradeEnrollment(ProfileUpgradeEnrollment metric);
+  static void LogProfileDesktopMenu(ProfileDesktopMenu metric,
+                                    signin::GAIA_SERVICE_TYPE gaia_service);
 
   // These functions should only be called on the UI thread because they hook
   // into g_browser_process through a helper function.
   static void LogProfileLaunch(Profile* profile);
   static void LogProfileSyncSignIn(const base::FilePath& profile_path);
   static void LogProfileUpdate(const base::FilePath& profile_path);
 };
 
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_