Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2884853002: cleanup unused incremental resolution (Closed)

Created:
3 years, 7 months ago by danrubel
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cleanup unused incremental resolution * remove unused analyzer incremental resolution * remove unused Token.applyDelta method Patch Set 1 is the original CL that was landed and reverted https://codereview.chromium.org/2876993005 Patsh Set 2 contains additional fixes and test changes R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d56690616761579b7a311e794cc43f45508ef272

Patch Set 1 #

Patch Set 2 : additional fixes and test changes #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3747 lines) Patch
M pkg/analysis_server/test/analysis/update_content_test.dart View 1 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 2 7 chunks +4 lines, -121 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +0 lines, -1150 lines 0 comments Download
D pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +0 lines, -2411 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 3 chunks +12 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 1 2 5 chunks +0 lines, -40 lines 0 comments Download
M pkg/front_end/test/fasta/bootstrap_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/front_end/test/token_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 7 months ago (2017-05-16 01:21:40 UTC) #2
scheglov
lgtm
3 years, 7 months ago (2017-05-16 02:08:02 UTC) #3
danrubel
3 years, 7 months ago (2017-05-16 11:53:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d56690616761579b7a311e794cc43f45508ef272 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698