Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 288483002: [fsp] Add histograms for opening files. (Closed)

Created:
6 years, 7 months ago by mtomasz
Modified:
6 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

[fsp] Add histograms for opening files. This is a split of https://codereview.chromium.org/284443002/, to avoid merging issues. It is almost impossible to land a CL adding histograms via CQ, without a merging conflict. TBR=isherman@chromium.org TEST=Just histograms, no actual changes. BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269968

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M extensions/browser/extension_function_histogram_value.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtomasz
@isherman: TBR PTAL. Thanks.
6 years, 7 months ago (2014-05-13 02:05:00 UTC) #1
mtomasz
Committed patchset #2 manually as r269968 (presubmit successful).
6 years, 7 months ago (2014-05-13 02:14:37 UTC) #2
Ilya Sherman
6 years, 7 months ago (2014-05-13 02:57:53 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698