[subresource_filter] Add custom strings/behavior on Desktop Page Info

components/page_info_strings.grdp

Index: components/page_info_strings.grdp
diff --git a/components/page_info_strings.grdp b/components/page_info_strings.grdp
index f1af7c44018c98eeb738cc6587cd787780207a36..bd74fb837e7c8fb05b5290ce0b83eed986a6a0b0 100644
--- a/components/page_info_strings.grdp
+++ b/components/page_info_strings.grdp
@@ -260,6 +260,10 @@
     <message name="IDS_PAGE_INFO_MENU_ITEM_DETECT_IMPORTANT_CONTENT" desc="The text of the menu item of a permissions menu on the Page Info UI that sets the setting to detect important content.">
       Always detect important content on this site
     </message>
+    <!-- IDS_PAGE_INFO_MENU_ITEM_SUBRESOURCE_FILTER_BLOCK is currently the same as IDS_PAGE_INFO_MENU_ITEM_BLOCK, but we use a different string identifier in the code for the flexibility to change it in the future. -->

[lgarron, 2017/05/17 20:27:23]

Nit: Update this to IDS_PAGE_INFO_MENU_ITEM_SUBRESOURCE_FILTER_BLOCK

[Charlie Harrison, 2017/05/17 20:29:49]

Sorry I'm not sure I understand this comment?

[Charlie Harrison, 2017/05/22 17:03:56]

lgarron: Quick ping?

[lgarron, 2017/05/22 20:09:32]

Sorry, I glanced at the strings wrong, and it looked like it was out of sync.
All good now.

[Charlie Harrison, 2017/05/22 20:10:15]

No worries, just making sure.

+    <message name="IDS_PAGE_INFO_MENU_ITEM_SUBRESOURCE_FILTER_BLOCK" desc="The text of the menu item of a permissions menu on the Page Info UI for the subresource filter permission in Block mode">
+      Always block on this site
+    </message>
 
     <!-- UI for device access granted to the site using the device chooser (e.g. USB, Bluetooth) -->
     <message name="IDS_PAGE_INFO_USB_DEVICE_LABEL" desc="The label used to describe a USB device that the user has granted the site permission to access.">